Summary: | Use AV descriptions in display for sort1/sort2 in basket display | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Acquisitions | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, emily.lamancusa, fridolin.somers, oleonard |
Version: | unspecified | Keywords: | rel_23_11_candidate |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
Circulation function: | |||
Bug Depends on: | 34618 | ||
Bug Blocks: | |||
Attachments: |
Bug 34752: Add AV handling to sort1/sort2 on baskets
Bug 34752: Add AV handling to sort1/sort2 on baskets Bug 34752: (QA follow-up) perltidy Bug 34752: Add AV handling to sort1/sort2 on baskets Bug 34752: (QA follow-up) perltidy |
Description
Martin Renvoize (ashimema)
2023-09-11 10:15:04 UTC
Created attachment 155474 [details] [review] Bug 34752: Add AV handling to sort1/sort2 on baskets This patch adds Authorized Value handling for the display of sort1 and sort2 fields in the acquisitions basket display page. Trivial follow-up to bug 34618.. I'm going straight to Signed off here as really it could have been done inline as a QA follow-up. Just one final set of eyes to double check it's all working as expected (with and without AV's configured for a pair of funds used in the same basket would be a great test). Created attachment 155526 [details] [review] Bug 34752: Add AV handling to sort1/sort2 on baskets This patch adds Authorized Value handling for the display of sort1 and sort2 fields in the acquisitions basket display page. Signed-off-by: David Nind <david@davidnind.com> Changing back to needs sign off - not sure I tested it correctly. Will leave for someone who understands this a bit more to sign off. For a test plan: * You need a budget and at least 2 funds. * For the funds select different AV for the statistic fields, leave at least one without any AV (will be a free text entry) * Create a basket * Add 2 order lines, using your different funds and different statistic settings Make sure you also type into the one without AV :) * Verify the AV show the correct description/text on the basket summary page (In reply to Katrin Fischer from comment #5) > For a test plan: Thanks Katrin! Looks like I did test it correctly, changing back to signed off. Created attachment 155718 [details] [review] Bug 34752: (QA follow-up) perltidy Trivial patch, works and makes sense. Passing QA Hi Elam, it looks like the first patch is missing your sign-off line, do you want to fix? And thx for QA! Created attachment 156993 [details] [review] Bug 34752: Add AV handling to sort1/sort2 on baskets This patch adds Authorized Value handling for the display of sort1 and sort2 fields in the acquisitions basket display page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: emlam <emily.lamancusa@montgomerycountymd.gov> Created attachment 156994 [details] [review] Bug 34752: (QA follow-up) perltidy Signed-off-by: emlam <emily.lamancusa@montgomerycountymd.gov> Added my sign-off lines (plus a trivial rebase) Pushed to master for 23.11. Nice work everyone, thanks! Depends on Bug 34618 not in 23.05.x |