It would be useful to be able to use the table column configurator to be able to add sort 1 and sort 2 to the basket view (table id "orders")
We use sort1 for 'Subject fund' and sort2 for 'Purchase reason'. To see the subject fund, we currently have to reopen the basket and scroll to the Modify button. This is a clumsy worflow, and having sort1 and sort2 able to be exposed would be very useful.
Being able to see the sort1 and sort2 fields in basket view without the need to reopen it and modify lines, when no modification is needed would be really helpful. It would also be useful for catching errros quicker. For a period, we hadn't noticed that the sort1 field wasn't being populated from our orders received by EDI. If there had been a means of seeing that field without opening the basket, our team would have caught the technical glitch a lot sooner.
Created attachment 154902 [details] [review] Bug 34618: Add sort 1 and 2 fields to basket in acquisitions This patch adds the option to display sort1 and sort2 columns in the view of the contents of a basket in acquisitions. The columns are labeled "Statistic 1" and "Statistic 2" to match the labels in the order creation/edit form. The fields are hidden by default in the updated table configuration. To test, apply the patch and restart services. - Go to acquisitions and create a basket if necessary: - Search for a vendor and click New -> Basket from the vendor toolbar on the vendor search results screen. - Create a basket, then click "Add to basket" from the basket details page. - Add an order to the basket. - With at least one order in the basket, check the table of orders in the basket. - The columns should be unchanged. - The table configuration button should show the two statistics fields as hidden. Test that they can be displayed. - Go to Administration -> Table settings. - Under Acquisitions -> basket, try changing the settings for the Statistic 1 and Statistic 2 fields, and check that your changes are reflected in the basket view. - Test with a vendor which has an EDI account: - Enable the EDIFACT system preference. - Go to Administration -> EDI accounts and create an account for your vendor. - Confirm that the table of orders in your basket still displays correctly now that the "Supplier report" column is present.
Created attachment 154935 [details] [review] Bug 34618: Add sort 1 and 2 fields to basket in acquisitions This patch adds the option to display sort1 and sort2 columns in the view of the contents of a basket in acquisitions. The columns are labeled "Statistic 1" and "Statistic 2" to match the labels in the order creation/edit form. The fields are hidden by default in the updated table configuration. To test, apply the patch and restart services. - Go to acquisitions and create a basket if necessary: - Search for a vendor and click New -> Basket from the vendor toolbar on the vendor search results screen. - Create a basket, then click "Add to basket" from the basket details page. - Add an order to the basket. - With at least one order in the basket, check the table of orders in the basket. - The columns should be unchanged. - The table configuration button should show the two statistics fields as hidden. Test that they can be displayed. - Go to Administration -> Table settings. - Under Acquisitions -> basket, try changing the settings for the Statistic 1 and Statistic 2 fields, and check that your changes are reflected in the basket view. - Test with a vendor which has an EDI account: - Enable the EDIFACT system preference. - Go to Administration -> EDI accounts and create an account for your vendor. - Confirm that the table of orders in your basket still displays correctly now that the "Supplier report" column is present. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Thank you, this is very helpful! Signed off :-)
Created attachment 154938 [details] [review] Bug 34618: Add sort 1 and 2 fields to basket in acquisitions This patch adds the option to display sort1 and sort2 columns in the view of the contents of a basket in acquisitions. The columns are labeled "Statistic 1" and "Statistic 2" to match the labels in the order creation/edit form. The fields are hidden by default in the updated table configuration. To test, apply the patch and restart services. - Go to acquisitions and create a basket if necessary: - Search for a vendor and click New -> Basket from the vendor toolbar on the vendor search results screen. - Create a basket, then click "Add to basket" from the basket details page. - Add an order to the basket. - With at least one order in the basket, check the table of orders in the basket. - The columns should be unchanged. - The table configuration button should show the two statistics fields as hidden. Test that they can be displayed. - Go to Administration -> Table settings. - Under Acquisitions -> basket, try changing the settings for the Statistic 1 and Statistic 2 fields, and check that your changes are reflected in the basket view. - Test with a vendor which has an EDI account: - Enable the EDIFACT system preference. - Go to Administration -> EDI accounts and create an account for your vendor. - Confirm that the table of orders in your basket still displays correctly now that the "Supplier report" column is present. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk>
Created attachment 155467 [details] [review] Bug 34618: Add sort 1 and 2 fields to basket in acquisitions This patch adds the option to display sort1 and sort2 columns in the view of the contents of a basket in acquisitions. The columns are labeled "Statistic 1" and "Statistic 2" to match the labels in the order creation/edit form. The fields are hidden by default in the updated table configuration. To test, apply the patch and restart services. - Go to acquisitions and create a basket if necessary: - Search for a vendor and click New -> Basket from the vendor toolbar on the vendor search results screen. - Create a basket, then click "Add to basket" from the basket details page. - Add an order to the basket. - With at least one order in the basket, check the table of orders in the basket. - The columns should be unchanged. - The table configuration button should show the two statistics fields as hidden. Test that they can be displayed. - Go to Administration -> Table settings. - Under Acquisitions -> basket, try changing the settings for the Statistic 1 and Statistic 2 fields, and check that your changes are reflected in the basket view. - Test with a vendor which has an EDI account: - Enable the EDIFACT system preference. - Go to Administration -> EDI accounts and create an account for your vendor. - Confirm that the table of orders in your basket still displays correctly now that the "Supplier report" column is present. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Simple and effective patch. QA script happy and no regressions. Passing QA
This will display the value as it is stored in the database, not taking into account that it's most often linked to an authorised value. But since the AV can vary between fund, maybe this could be solved on a separate follow-up bug?
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x
Nothing to add to the manual. The table is already listed as being configurable and we don't list the specific columns.