| Summary: | after_biblio_action hooks: find after delete makes no sense | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.11
|
|
| Circulation function: | |||
| Bug Depends on: | 22709 | ||
| Bug Blocks: | 35965 | ||
| Attachments: |
Bug 34786: after_biblio_action hooks - No find when action is delete
Bug 34786: after_biblio_action hooks - No find when action is delete |
||
Created attachment 155605 [details] [review] Bug 34786: after_biblio_action hooks - No find when action is delete Test plan: Run t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Super trivial: self SO Created attachment 155799 [details] [review] Bug 34786: after_biblio_action hooks - No find when action is delete Test plan: Run t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial improvement.. Passing QA Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |
$error = _koha_delete_biblio( $dbh, $biblionumber ); _after_biblio_action_hooks({ action => 'delete', biblio_id => $biblionumber }); AND my $biblio_id = $args->{biblio_id}; my $action = $args->{action}; my $biblio = Koha::Biblios->find( $biblio_id ); Makes no sense.