$error = _koha_delete_biblio( $dbh, $biblionumber ); _after_biblio_action_hooks({ action => 'delete', biblio_id => $biblionumber }); AND my $biblio_id = $args->{biblio_id}; my $action = $args->{action}; my $biblio = Koha::Biblios->find( $biblio_id ); Makes no sense.
Created attachment 155605 [details] [review] Bug 34786: after_biblio_action hooks - No find when action is delete Test plan: Run t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Super trivial: self SO
Created attachment 155799 [details] [review] Bug 34786: after_biblio_action hooks - No find when action is delete Test plan: Run t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial improvement.. Passing QA
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x