Description
Owen Leonard
2023-09-21 17:05:17 UTC
Created attachment 156104 [details] [review] Bug 34869: Convert OPACResultsSidebar system preference to news block This patch moves the OPACResultsSidebar system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the OPACResultsSidebar system preference before applying the patch. Apply the patch and run the database update process. - Go to the OPAC and perform a catalog search. - Confirm that the content in the sidebar under the search facets, which was previously in the OPACResultsSidebar system preference, is still displayed. - In the staff client, go to Tools -> HTML customizations and verify that the content from OPACResultsSidebar is now stored there. - The HTML customization entry form should offer OPACResultsSidebar as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the OPACResultsSidebar HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Perform another catalog search to confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and confirm that the OpacCustomSearch preference has been removed. Created attachment 156106 [details] [review] Bug 34869: Convert OPACResultsSidebar system preference to HTML customization This patch moves the OPACResultsSidebar system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the OPACResultsSidebar system preference before applying the patch. Apply the patch and run the database update process. - Go to the OPAC and perform a catalog search. - Confirm that the content in the sidebar under the search facets, which was previously in the OPACResultsSidebar system preference, is still displayed. - In the staff client, go to Tools -> HTML customizations and verify that the content from OPACResultsSidebar is now stored there. - The HTML customization entry form should offer OPACResultsSidebar as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the OPACResultsSidebar HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Perform another catalog search to confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and confirm that the OpacCustomSearch preference has been removed. Created attachment 156108 [details] [review] Bug 34869: Convert OPACResultsSidebar system preference to HTML customization This patch moves the OPACResultsSidebar system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the OPACResultsSidebar system preference before applying the patch. Apply the patch and run the database update process. - Go to the OPAC and perform a catalog search. - Confirm that the content in the sidebar under the search facets, which was previously in the OPACResultsSidebar system preference, is still displayed. - In the staff client, go to Tools -> HTML customizations and verify that the content from OPACResultsSidebar is now stored there. - The HTML customization entry form should offer OPACResultsSidebar as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the OPACResultsSidebar HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Perform another catalog search to confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and confirm that the OpacCustomSearch preference has been removed. Created attachment 156110 [details] [review] Bug 34869: Convert OPACResultsSidebar system preference to HTML customization This patch moves the OPACResultsSidebar system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the OPACResultsSidebar system preference before applying the patch. Apply the patch and run the database update process. - Go to the OPAC and perform a catalog search. - Confirm that the content in the sidebar under the search facets, which was previously in the OPACResultsSidebar system preference, is still displayed. - In the staff client, go to Tools -> HTML customizations and verify that the content from OPACResultsSidebar is now stored there. - The HTML customization entry form should offer OPACResultsSidebar as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the OPACResultsSidebar HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Perform another catalog search to confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and confirm that the OPACResultsSidebar preference has been removed. Created attachment 156126 [details] [review] Bug 34869: Convert OPACResultsSidebar system preference to HTML customization This patch moves the OPACResultsSidebar system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the OPACResultsSidebar system preference before applying the patch. Apply the patch and run the database update process. - Go to the OPAC and perform a catalog search. - Confirm that the content in the sidebar under the search facets, which was previously in the OPACResultsSidebar system preference, is still displayed. - In the staff client, go to Tools -> HTML customizations and verify that the content from OPACResultsSidebar is now stored there. - The HTML customization entry form should offer OPACResultsSidebar as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the OPACResultsSidebar HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Perform another catalog search to confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and confirm that the OPACResultsSidebar preference has been removed. Signed-off-by: David Nind <david@davidnind.com> Created attachment 156681 [details] [review] Bug 34869: Convert OPACResultsSidebar system preference to HTML customization This patch moves the OPACResultsSidebar system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the OPACResultsSidebar system preference before applying the patch. Apply the patch and run the database update process. - Go to the OPAC and perform a catalog search. - Confirm that the content in the sidebar under the search facets, which was previously in the OPACResultsSidebar system preference, is still displayed. - In the staff client, go to Tools -> HTML customizations and verify that the content from OPACResultsSidebar is now stored there. - The HTML customization entry form should offer OPACResultsSidebar as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the OPACResultsSidebar HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Perform another catalog search to confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and confirm that the OPACResultsSidebar preference has been removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Please rebase ASAP. Thanks! Created attachment 157564 [details] [review] Bug 34869: Convert OPACResultsSidebar system preference to HTML customization This patch moves the OPACResultsSidebar system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the OPACResultsSidebar system preference before applying the patch. Apply the patch and run the database update process. - Go to the OPAC and perform a catalog search. - Confirm that the content in the sidebar under the search facets, which was previously in the OPACResultsSidebar system preference, is still displayed. - In the staff client, go to Tools -> HTML customizations and verify that the content from OPACResultsSidebar is now stored there. - The HTML customization entry form should offer OPACResultsSidebar as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the OPACResultsSidebar HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Perform another catalog search to confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and confirm that the OPACResultsSidebar preference has been removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Hi, I'm sorry to say that having pushed bug 31383 made this require some more work on the atomicupdate, as the language-specific portion of the `additional_contents` table has been moved into `additional_contents_localizations`. Ping Created attachment 157805 [details] [review] Bug 34869: (follow-up) Revise database update following Bug 31383 I think the first INSERT should be out of the loop. I want QA on this. Created attachment 157821 [details] [review] Bug 34869: (follow-up) Add entry to HTML customization help include Created attachment 157823 [details] [review] Bug 34869: Convert OPACResultsSidebar system preference to HTML customization This patch moves the OPACResultsSidebar system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the OPACResultsSidebar system preference before applying the patch. Apply the patch and run the database update process. - Go to the OPAC and perform a catalog search. - Confirm that the content in the sidebar under the search facets, which was previously in the OPACResultsSidebar system preference, is still displayed. - In the staff client, go to Tools -> HTML customizations and verify that the content from OPACResultsSidebar is now stored there. - The HTML customization entry form should offer OPACResultsSidebar as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the OPACResultsSidebar HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Perform another catalog search to confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and confirm that the OPACResultsSidebar preference has been removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 157824 [details] [review] Bug 34869: (follow-up) Revise database update following Bug 31383 Created attachment 157825 [details] [review] Bug 34869: (follow-up) Add entry to HTML customization help include Created attachment 157907 [details] [review] Bug 34869: Convert OPACResultsSidebar system preference to HTML customization This patch moves the OPACResultsSidebar system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the OPACResultsSidebar system preference before applying the patch. Apply the patch and run the database update process. - Go to the OPAC and perform a catalog search. - Confirm that the content in the sidebar under the search facets, which was previously in the OPACResultsSidebar system preference, is still displayed. - In the staff client, go to Tools -> HTML customizations and verify that the content from OPACResultsSidebar is now stored there. - The HTML customization entry form should offer OPACResultsSidebar as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the OPACResultsSidebar HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Perform another catalog search to confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and confirm that the OPACResultsSidebar preference has been removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 157908 [details] [review] Bug 34869: (follow-up) Revise database update following Bug 31383 Created attachment 157909 [details] [review] Bug 34869: (follow-up) Add entry to HTML customization help include Created attachment 158095 [details] [review] Bug 34869: Convert OPACResultsSidebar system preference to HTML customization This patch moves the OPACResultsSidebar system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the OPACResultsSidebar system preference before applying the patch. Apply the patch and run the database update process. - Go to the OPAC and perform a catalog search. - Confirm that the content in the sidebar under the search facets, which was previously in the OPACResultsSidebar system preference, is still displayed. - In the staff client, go to Tools -> HTML customizations and verify that the content from OPACResultsSidebar is now stored there. - The HTML customization entry form should offer OPACResultsSidebar as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the OPACResultsSidebar HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Perform another catalog search to confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and confirm that the OPACResultsSidebar preference has been removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158096 [details] [review] Bug 34869: (follow-up) Revise database update following Bug 31383 Created attachment 158097 [details] [review] Bug 34869: (follow-up) Add entry to HTML customization help include Created attachment 158444 [details] [review] Bug 34869: Convert OPACResultsSidebar system preference to HTML customization This patch moves the OPACResultsSidebar system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the OPACResultsSidebar system preference before applying the patch. Apply the patch and run the database update process. - Go to the OPAC and perform a catalog search. - Confirm that the content in the sidebar under the search facets, which was previously in the OPACResultsSidebar system preference, is still displayed. - In the staff client, go to Tools -> HTML customizations and verify that the content from OPACResultsSidebar is now stored there. - The HTML customization entry form should offer OPACResultsSidebar as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the OPACResultsSidebar HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Perform another catalog search to confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and confirm that the OPACResultsSidebar preference has been removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158445 [details] [review] Bug 34869: (follow-up) Revise database update following Bug 31383 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158446 [details] [review] Bug 34869: (follow-up) Add entry to HTML customization help include Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |