Building on 22318, the PatronSelfRegistrationAdditionalInstructions system preference should be converted to an HTML customization option.
Created attachment 156111 [details] [review] Bug 34889: Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization This patch moves the PatronSelfRegistrationAdditionalInstructions system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the PatronSelfRegistrationAdditionalInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content previously in the PatronSelfRegistrationAdditionalInstructions preference is now stored there. - The HTML customization entry form should offer PatronSelfRegistrationAdditionalInstructions as a choice under "Display location." - Go to Administration -> System preferences and enable "PatronSelfRegistration." Set "PatronSelfRegistrationVerifyByEmail" to "Don't require." - Go to the OPAC and click "Register here." - Submit a new registration and confirm that the content that was previously stored in the system preference is shown correctly on the registration confirmation page. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the PatronSelfRegistrationAdditionalInstructions HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Complete the online registration process again to confirm that the content you added for your translation shows up correctly on the confirmation page. - Go to Administration -> System preferences and confirm that the PatronSelfRegistrationAdditionalInstructions preference has been removed.
Owen, I am having trouble getting content to appear when language packs are installed. I have installed both fr-FR and es-ES, turned them on, and added content in the right place for that language. Then I am switching to that language and registering. Maybe I am missing something but can you check once more?
Created attachment 156136 [details] [review] Bug 34889: Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization This patch moves the PatronSelfRegistrationAdditionalInstructions system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the PatronSelfRegistrationAdditionalInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content previously in the PatronSelfRegistrationAdditionalInstructions preference is now stored there. - The HTML customization entry form should offer PatronSelfRegistrationAdditionalInstructions as a choice under "Display location." - Go to Administration -> System preferences and enable "PatronSelfRegistration." Set "PatronSelfRegistrationVerifyByEmail" to "Don't require." - Go to the OPAC and click "Register here." - Submit a new registration and confirm that the content that was previously stored in the system preference is shown correctly on the registration confirmation page. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the PatronSelfRegistrationAdditionalInstructions HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Complete the online registration process again to confirm that the content you added for your translation shows up correctly on the confirmation page. - Go to Administration -> System preferences and confirm that the PatronSelfRegistrationAdditionalInstructions preference has been removed. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 156680 [details] [review] Bug 34889: Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization This patch moves the PatronSelfRegistrationAdditionalInstructions system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the PatronSelfRegistrationAdditionalInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content previously in the PatronSelfRegistrationAdditionalInstructions preference is now stored there. - The HTML customization entry form should offer PatronSelfRegistrationAdditionalInstructions as a choice under "Display location." - Go to Administration -> System preferences and enable "PatronSelfRegistration." Set "PatronSelfRegistrationVerifyByEmail" to "Don't require." - Go to the OPAC and click "Register here." - Submit a new registration and confirm that the content that was previously stored in the system preference is shown correctly on the registration confirmation page. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the PatronSelfRegistrationAdditionalInstructions HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Complete the online registration process again to confirm that the content you added for your translation shows up correctly on the confirmation page. - Go to Administration -> System preferences and confirm that the PatronSelfRegistrationAdditionalInstructions preference has been removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Lucas Gass from comment #2) > Owen, > > I am having trouble getting content to appear when language packs are > installed. > > I have installed both fr-FR and es-ES, turned them on, and added content in > the right place for that language. Then I am switching to that language and > registering. > > Maybe I am missing something but can you check once more? I did some double checking and it seemed to work all ok. Some thing to keep in mind is that we need to set a publication date for things to show up at all. That's something that trapped me at first.
Please rebase ASAP. Thanks!
Created attachment 157563 [details] [review] Bug 34889: Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization This patch moves the PatronSelfRegistrationAdditionalInstructions system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the PatronSelfRegistrationAdditionalInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content previously in the PatronSelfRegistrationAdditionalInstructions preference is now stored there. - The HTML customization entry form should offer PatronSelfRegistrationAdditionalInstructions as a choice under "Display location." - Go to Administration -> System preferences and enable "PatronSelfRegistration." Set "PatronSelfRegistrationVerifyByEmail" to "Don't require." - Go to the OPAC and click "Register here." - Submit a new registration and confirm that the content that was previously stored in the system preference is shown correctly on the registration confirmation page. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the PatronSelfRegistrationAdditionalInstructions HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Complete the online registration process again to confirm that the content you added for your translation shows up correctly on the confirmation page. - Go to Administration -> System preferences and confirm that the PatronSelfRegistrationAdditionalInstructions preference has been removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Hi, I'm sorry to say that having pushed bug 31383 made this require some more work on the atomicupdate, as the language-specific portion of the `additional_contents` table has been moved into `additional_contents_localizations`.
PIng
Created attachment 157808 [details] [review] Bug 34889: (follow-up) Revise database update following Bug 31383
Look at my reason to fail on bug 34869.
Created attachment 157809 [details] [review] Bug 34889: (follow-up) Add entry to HTML customization help include
Created attachment 157826 [details] [review] Bug 34889: Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization This patch moves the PatronSelfRegistrationAdditionalInstructions system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the PatronSelfRegistrationAdditionalInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content previously in the PatronSelfRegistrationAdditionalInstructions preference is now stored there. - The HTML customization entry form should offer PatronSelfRegistrationAdditionalInstructions as a choice under "Display location." - Go to Administration -> System preferences and enable "PatronSelfRegistration." Set "PatronSelfRegistrationVerifyByEmail" to "Don't require." - Go to the OPAC and click "Register here." - Submit a new registration and confirm that the content that was previously stored in the system preference is shown correctly on the registration confirmation page. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the PatronSelfRegistrationAdditionalInstructions HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Complete the online registration process again to confirm that the content you added for your translation shows up correctly on the confirmation page. - Go to Administration -> System preferences and confirm that the PatronSelfRegistrationAdditionalInstructions preference has been removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 157827 [details] [review] Bug 34889: (follow-up) Revise database update following Bug 31383
Created attachment 157828 [details] [review] Bug 34889: (follow-up) Add entry to HTML customization help include
Created attachment 157910 [details] [review] Bug 34889: Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization This patch moves the PatronSelfRegistrationAdditionalInstructions system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the PatronSelfRegistrationAdditionalInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content previously in the PatronSelfRegistrationAdditionalInstructions preference is now stored there. - The HTML customization entry form should offer PatronSelfRegistrationAdditionalInstructions as a choice under "Display location." - Go to Administration -> System preferences and enable "PatronSelfRegistration." Set "PatronSelfRegistrationVerifyByEmail" to "Don't require." - Go to the OPAC and click "Register here." - Submit a new registration and confirm that the content that was previously stored in the system preference is shown correctly on the registration confirmation page. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the PatronSelfRegistrationAdditionalInstructions HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Complete the online registration process again to confirm that the content you added for your translation shows up correctly on the confirmation page. - Go to Administration -> System preferences and confirm that the PatronSelfRegistrationAdditionalInstructions preference has been removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 157911 [details] [review] Bug 34889: (follow-up) Revise database update following Bug 31383
Created attachment 157912 [details] [review] Bug 34889: (follow-up) Add entry to HTML customization help include
Created attachment 158447 [details] [review] Bug 34889: Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization This patch moves the PatronSelfRegistrationAdditionalInstructions system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the PatronSelfRegistrationAdditionalInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content previously in the PatronSelfRegistrationAdditionalInstructions preference is now stored there. - The HTML customization entry form should offer PatronSelfRegistrationAdditionalInstructions as a choice under "Display location." - Go to Administration -> System preferences and enable "PatronSelfRegistration." Set "PatronSelfRegistrationVerifyByEmail" to "Don't require." - Go to the OPAC and click "Register here." - Submit a new registration and confirm that the content that was previously stored in the system preference is shown correctly on the registration confirmation page. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the PatronSelfRegistrationAdditionalInstructions HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Complete the online registration process again to confirm that the content you added for your translation shows up correctly on the confirmation page. - Go to Administration -> System preferences and confirm that the PatronSelfRegistrationAdditionalInstructions preference has been removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 158448 [details] [review] Bug 34889: (follow-up) Revise database update following Bug 31383 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 158449 [details] [review] Bug 34889: (follow-up) Add entry to HTML customization help include Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x