| Summary: | Merge Patron.t into t/db/Koha/Patron.t | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.05,22.11.11
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 34336 | ||
| Attachments: |
Bug 34887: Remove Test::DBIx::Class from Patron.t
Bug 34887: Fix transactions in db dependent Patron.t Bug 34887: Merge with db_dependent Patron.t Bug 34887: Remove Test::DBIx::Class from Patron.t Bug 34887: Fix transactions in db dependent Patron.t Bug 34887: Merge with db_dependent Patron.t |
||
|
Description
Marcel de Rooy
2023-09-22 13:53:52 UTC
Created attachment 156128 [details] [review] Bug 34887: Remove Test::DBIx::Class from Patron.t Moving all tests into one subtest with two underlying subtests for checking accessors after new or set. This will make it more easy to merge with the db dependent counterpart. Test plan: Run t/Patron.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 156129 [details] [review] Bug 34887: Fix transactions in db dependent Patron.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 156130 [details] [review] Bug 34887: Merge with db_dependent Patron.t Test plan: Run t/db_dependent/Koha/Patron.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Moving to SO. Trivial exercise. Run the test ! Created attachment 156207 [details] [review] Bug 34887: Remove Test::DBIx::Class from Patron.t Moving all tests into one subtest with two underlying subtests for checking accessors after new or set. This will make it more easy to merge with the db dependent counterpart. Test plan: Run t/Patron.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 156208 [details] [review] Bug 34887: Fix transactions in db dependent Patron.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 156209 [details] [review] Bug 34887: Merge with db_dependent Patron.t Test plan: Run t/db_dependent/Koha/Patron.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> JD amended patch: Fixed QA failures FAIL t/db_dependent/Koha/Patron.t FAIL spelling personnal ==> personal personnal ==> personal personnal ==> personal personnal ==> personal WARN tidiness The file is less tidy than before (bad/messy lines before: 361, now: 382) Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.05 Nice work everyone! Pushed to oldstable for 22.11.x |