See 33833 Our use is limited. The tests are harder to read imo than the TestBuilder tests, but that could be a personal idea. Using the module may hide/oversimplify what we actually need. When removing the module somewhere, a constraint came up that was hidden by TDC but should be dealt with in the test. The module has a history of laborious installing but that is probably history. I opt for removing it in the few tests using it. What do you think?
I don't know enough about its usage but it looks like it hasn't been updated since 2016. At a glance, it seems like it might be better for smaller simpler projects.
I don't really see any real benefit of keeping it around at this stage. As some point, I like the idea of trying to make a more database independent test set.. but in reality, the integration tests we have are in many ways more helpful.
Go ahead!
(In reply to Marcel de Rooy from comment #0) > See 33833 > > The module has a history of laborious installing but that is probably > history. some good news, the package has arrived in debian/ubuntu stable https://packages.debian.org/bookworm/all/libtest-dbix-class-perl
(In reply to Mason James from comment #4) > (In reply to Marcel de Rooy from comment #0) > > See 33833 > > > > The module has a history of laborious installing but that is probably > > history. > > some good news, the package has arrived in debian/ubuntu stable > > https://packages.debian.org/bookworm/all/libtest-dbix-class-perl More good news: We are almost ready to remove it.
Created attachment 156589 [details] [review] Bug 34336: Remove the dependency for Test::DBIx::Class The module is removed from t. We only have 01-test_dbic.t and we do not need it any longer. Test plan: git grep for Test::DBIx::Class. You should only see release notes. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Trivial last patch in a series: Self SO
Created attachment 156616 [details] [review] Bug 34336: Remove the dependency for Test::DBIx::Class The module is removed from t. We only have 01-test_dbic.t and we do not need it any longer. Test plan: git grep for Test::DBIx::Class. You should only see release notes. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Thank you guys. You are awesome.
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x