Summary: | View restrictions button (patrons page) doesn't link to tab | ||
---|---|---|---|
Product: | Koha | Reporter: | David Nind <david> |
Component: | Patrons | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
Severity: | minor | ||
Priority: | P5 - low | CC: | emily.lamancusa, fridolin.somers, gmcharlt, kyle.m.hall, matt.blenkinsop |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.05
|
|
Circulation function: | |||
Bug Depends on: | 33528 | ||
Bug Blocks: | |||
Attachments: |
Bug 34891: Correct link on view restrictions button
Bug 34891: Correct link on view restrictions button Bug 34891: Correct link on view restrictions button |
Description
David Nind
2023-09-22 16:27:33 UTC
Created attachment 156116 [details] [review] Bug 34891: Correct link on view restrictions button This patch updates the button which appears on the circulation page when a patron is restricted. Before this patch, clicking the button would activate the restrictions tab but wouldn't scroll the page to make the tab visible. To test, apply the patch and check out to a patron who has one or more restrictions. - There should be a message on the page, "Restricted since..." - Click the "View restrictions" button. - The page should jump down so that the tabs are visible and the restrictions tab should be active. - Test on the patron details page too. Created attachment 156119 [details] [review] Bug 34891: Correct link on view restrictions button This patch updates the button which appears on the circulation page when a patron is restricted. Before this patch, clicking the button would activate the restrictions tab but wouldn't scroll the page to make the tab visible. To test, apply the patch and check out to a patron who has one or more restrictions. - There should be a message on the page, "Restricted since..." - Click the "View restrictions" button. - The page should jump down so that the tabs are visible and the restrictions tab should be active. - Test on the patron details page too. Signed-off-by: David Nind <david@davidnind.com> Created attachment 156339 [details] [review] Bug 34891: Correct link on view restrictions button This patch updates the button which appears on the circulation page when a patron is restricted. Before this patch, clicking the button would activate the restrictions tab but wouldn't scroll the page to make the tab visible. To test, apply the patch and check out to a patron who has one or more restrictions. - There should be a message on the page, "Restricted since..." - Click the "View restrictions" button. - The page should jump down so that the tabs are visible and the restrictions tab should be active. - Test on the patron details page too. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Trivial patch, nice fix, QA script is happy. Passing QA. Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.05 Dependency missing for 22.11.x - not backporting |