When there are restrictions on a patron's account, the 'View restrictions' button that appears after the list of restrictions doesn't scroll you down to the restrictions tab (on either the check out or details tab). To replicate: 1. For any patron, add a restriction (Patrons > [patron] > Check out or Details tab > Add manual restriction). 2. The restriction is now listed at the top of the page, with a 'View restrictions' button. 3. Note that if you click the 'View restrictions' button: - It opens the Restrictions tab, - But doesn't scroll down the page to the actual tab 4. This is more evident on the details section of the patron account.
Created attachment 156116 [details] [review] Bug 34891: Correct link on view restrictions button This patch updates the button which appears on the circulation page when a patron is restricted. Before this patch, clicking the button would activate the restrictions tab but wouldn't scroll the page to make the tab visible. To test, apply the patch and check out to a patron who has one or more restrictions. - There should be a message on the page, "Restricted since..." - Click the "View restrictions" button. - The page should jump down so that the tabs are visible and the restrictions tab should be active. - Test on the patron details page too.
Created attachment 156119 [details] [review] Bug 34891: Correct link on view restrictions button This patch updates the button which appears on the circulation page when a patron is restricted. Before this patch, clicking the button would activate the restrictions tab but wouldn't scroll the page to make the tab visible. To test, apply the patch and check out to a patron who has one or more restrictions. - There should be a message on the page, "Restricted since..." - Click the "View restrictions" button. - The page should jump down so that the tabs are visible and the restrictions tab should be active. - Test on the patron details page too. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 156339 [details] [review] Bug 34891: Correct link on view restrictions button This patch updates the button which appears on the circulation page when a patron is restricted. Before this patch, clicking the button would activate the restrictions tab but wouldn't scroll the page to make the tab visible. To test, apply the patch and check out to a patron who has one or more restrictions. - There should be a message on the page, "Restricted since..." - Click the "View restrictions" button. - The page should jump down so that the tabs are visible and the restrictions tab should be active. - Test on the patron details page too. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Trivial patch, nice fix, QA script is happy. Passing QA.
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.05
Dependency missing for 22.11.x - not backporting