Summary: | ILL - "Place request with partners" icon is gone | ||
---|---|---|---|
Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
Component: | ILL | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, pedro.amorim |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
23.11.00
|
Circulation function: | |
Bug Depends on: | 32910 | ||
Bug Blocks: | |||
Attachments: |
Bug 34905: Fix icon
Bug 34905: Fix icon Bug 34905: Fix icon |
Description
Pedro Amorim
2023-09-25 16:08:07 UTC
Created attachment 156180 [details] [review] Bug 34905: Fix icon Test plan, on k-t-d: 1) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Create a new FreeForm ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 3) Pick a request type and input "42" in cardnumber and select a random library. 4) Notice the "Place request with partners" icon is gone from the top action bar. 5) Apply patch. Repeat. Created attachment 156181 [details] [review] Bug 34905: Fix icon Test plan, on k-t-d: 1) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Create a new FreeForm ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 3) Pick a request type and input "42" in cardnumber and select a random library. 4) Notice the "Place request with partners" icon is gone from the top action bar. 5) Apply patch. Repeat. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 156388 [details] [review] Bug 34905: Fix icon Test plan, on k-t-d: 1) Install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Create a new FreeForm ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 3) Pick a request type and input "42" in cardnumber and select a random library. 4) Notice the "Place request with partners" icon is gone from the top action bar. 5) Apply patch. Repeat. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 23.11. Nice work everyone, thanks! |