Bug 32910 - Upgrade fontawesome icons to V6
Summary: Upgrade fontawesome icons to V6
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: https://gitlab.com/joubu/Koha/-/commi...
Keywords:
: 32018 (view as bug list)
Depends on:
Blocks: 33988 33998 34042 34112 34129 34320 34322 34905 35013
  Show dependency treegraph
 
Reported: 2023-02-08 14:56 UTC by Jonathan Druart
Modified: 2023-12-12 21:34 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 32910: Adjust fontawesome icons ref (63.94 KB, patch)
2023-02-08 14:59 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32910: Fix 'Agreements' icon (1.15 KB, patch)
2023-06-16 13:12 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-02-08 14:56:58 UTC

    
Comment 1 Jonathan Druart 2023-02-08 14:59:03 UTC
Created attachment 146396 [details] [review]
Bug 32910: Adjust fontawesome icons ref
Comment 2 Jonathan Druart 2023-02-08 15:04:56 UTC
I had a quick try at upgrading to V6, but it needs more attention.

Especially a better focus on those 2 pages:
https://fontawesome.com/v5/docs/web/setup/upgrade-from-v4
https://fontawesome.com/docs/web/setup/upgrade/
Comment 3 Jonathan Druart 2023-02-08 15:05:19 UTC
I didn't manage to attach the patches here, see https://gitlab.com/joubu/Koha/-/commits/bug_32910
Comment 4 Owen Leonard 2023-02-10 20:24:09 UTC
I have made some follow-up changes:

https://gitlab.com/koha-dev/koha-dev/-/tree/bug_32910
Comment 5 Martin Renvoize 2023-02-14 09:32:24 UTC
I tested Owens branch and couldn't find any obvious regressions, it's looking great and I can't wait to start using the new set.

I'm going to mark the bug as signed off, please add my SO line to the relevant branch when appropriate :).
Comment 6 Owen Leonard 2023-02-14 19:41:56 UTC
Jonathan we're already installing some Font Awesome assets via npm, correct? For ERM? I'm wondering if we shouldn't also get the FA SCSS from there and add it to the SCSS build.
Comment 7 Jonathan Druart 2023-02-15 08:18:04 UTC
(In reply to Owen Leonard from comment #6)
> Jonathan we're already installing some Font Awesome assets via npm, correct?
> For ERM? I'm wondering if we shouldn't also get the FA SCSS from there and
> add it to the SCSS build.

Yes, we are using some fontawesome vue modules, but not a lot, and not for all the icons we use in vue files.

See the output of
% git grep awesome koha-tmpl/intranet-tmpl/prog/js/vue # Vue module
vs
% git grep fa- koha-tmpl/intranet-tmpl/prog/js/vue # Not vue module

At this point we should actually the vue module them from there. The problem is that we are using edit/show/delete icons in the "Actions" columns of the tables, and we cannot use them there.


So, yes, we could install them differently, but not because we are doing it differently for Vue ;)
Comment 8 Martin Renvoize 2023-02-15 09:04:50 UTC
I think it's a great idea to shift installation of these assets to the build process.. :)
Comment 9 Jonathan Druart 2023-02-23 11:18:18 UTC
Let push and see how it goes?
Comment 10 Jonathan Druart 2023-02-23 11:21:12 UTC Comment hidden (obsolete)
Comment 11 Jonathan Druart 2023-02-23 11:21:45 UTC
Signed-off-by lines and rebase at https://gitlab.com/joubu/Koha/-/commits/bug_32910
Comment 12 Tomás Cohen Arazi 2023-03-14 12:02:33 UTC
Owen, can you please rebase?
Comment 13 Katrin Fischer 2023-04-30 10:39:55 UTC
Any chance for this one still? I'd like to pick a new icon for inventory from the newer version :)
Comment 14 Jonathan Druart 2023-05-02 07:16:25 UTC
(In reply to Jonathan Druart from comment #9)
> Let push and see how it goes?

This was more than 2 months ago, to have time to fix before the release. Now we are few weeks before the release. Why did we have wait so much time to push it? 
These patches are unnecessary painful to rebase!

Are we part of a kind of masochist secret group?
Comment 15 Jonathan Druart 2023-05-02 07:39:23 UTC
Too many conflicts, I am giving up.
Comment 16 Jonathan Druart 2023-05-02 07:41:50 UTC
On top of the remote branch, I think there are some occurrences missing

% git grep '\-o"' **/*.tt **/*.inc
Comment 17 Tomás Cohen Arazi 2023-05-02 12:16:46 UTC
(In reply to Jonathan Druart from comment #14)
> (In reply to Jonathan Druart from comment #9)
> > Let push and see how it goes?
> 
> This was more than 2 months ago, to have time to fix before the release. Now
> we are few weeks before the release. Why did we have wait so much time to
> push it? 

I was willing to push it once I noticed it existed, but it already needed a rebase. I guess we've been busy with other things...
Comment 18 Owen Leonard 2023-05-02 16:18:08 UTC
I've rebased this branch: https://gitlab.com/koha-dev/koha-dev/-/tree/bug_32910
Comment 19 Owen Leonard 2023-05-02 16:20:50 UTC
(In reply to Owen Leonard from comment #18)
> I've rebased this branch

Before seeing comment 16, so there are still a few missing
Comment 20 Tomás Cohen Arazi 2023-05-03 12:01:11 UTC
Early push candidate for 23.11
Comment 21 Jonathan Druart 2023-05-04 06:40:02 UTC
Thanks Owen!

I think there is this one left:
koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt:        .fa-file-archive-o {


Also, are you sure we need v4-shims?
Comment 22 Owen Leonard 2023-05-16 14:46:44 UTC
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt:       
> .fa-file-archive-o {

Remote branch rebased again and updated to fix a couple more missing references and to remove unused assets from the staff interface and OPAC
 
https://gitlab.com/koha-dev/koha-dev/-/tree/bug_32910
Comment 23 Tomás Cohen Arazi 2023-06-12 14:51:40 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 24 Tomás Cohen Arazi 2023-06-14 13:43:56 UTC
I pushed a follow-up to fix Asset.t
Comment 25 Jonathan Druart 2023-06-16 13:12:13 UTC
Created attachment 152412 [details] [review]
Bug 32910: Fix 'Agreements' icon
Comment 26 Tomás Cohen Arazi 2023-06-16 13:56:17 UTC
Follow-up pushed to master. Thanks Jonathan!
Comment 27 Owen Leonard 2023-06-27 11:47:57 UTC
*** Bug 32018 has been marked as a duplicate of this bug. ***
Comment 28 Martin Renvoize 2023-07-17 07:16:14 UTC
I would have loved to have seen this in 23.05.x, but for now, I can't justify this enhancement.
Comment 29 Caroline Cyr La Rose 2023-12-12 21:34:18 UTC
I think the screenshots will be updated as we document other things. Unless this changes something specific, I will make it resolved. Feel free to reopen with more details if I'm wrong...