Bug 34935

Summary: ERM - "Agreement user" and "License user" not translatable
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: I18N/L10NAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: f.demians
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Caroline Cyr La Rose 2023-09-27 16:27:52 UTC 
When adding an agreement in the ERM module, you can add users linked to that agreement. For each new user, there is a heading "Agreement user 1", "Agreement user 2", etc. This heading doesn't seem to be translatable. The only "Agreement user" I found in the po files is "Agreement user %s is missing a user".

To get there:

1. Enable ERMModule

2. Go to ERM > Agreements > New agreement > Add new user
--> A new heading says "Agreement user 1 Remove this user"

3. Update the po files

gulp po:update --lang fr-CA

4. Search the po files for "Agreement user"

grep "Agreement user" misc/translator/po/fr-CA*

--> The string is not in the po files
Comment 1 Caroline Cyr La Rose 2023-09-27 18:24:10 UTC 
I just noticed that it is the same for "License user"
Comment 2 Katrin Fischer 2024-01-13 15:16:34 UTC 
Verified this is still valid, I also found the spot in the code, but I am not sure how to fix it:

koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesFormAdd.vue

                <UserRoles
                    :user_type="$__('License user %s')"
                    :user_roles="license.user_roles"
                    :av_user_roles="av_user_roles"
                />

... and the same for "Agreement user".