Summary: | Typo: brower | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | Templates | Assignee: | David Nind <david> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, fridolin.somers, martin.renvoize |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.05,22.11.11
|
|
Circulation function: | |||
Attachments: |
Bug 34942: Fix typo - 'brower' to 'browser'
Bug 34942: Fix typo - 'brower' to 'browser' Bug 34942: Fix typo - 'brower' to 'browser' |
Description
Magnus Enger
2023-09-28 06:52:51 UTC
Created attachment 156439 [details] [review] Bug 34942: Fix typo - 'brower' to 'browser' This fixes a typo in a message used in the advanced cataloguing editor when macros are converted from being stored in the browser to being stored in the database (bug 17268 - Advanced cataloging editor - rancor - macros are lost when browser storage cleared). Test plan: 1. Search for 'brower' in the codebase - there should be one occurance: grep -rn --exclude=*.po brower * 2. Apply the patch. 3. Run the search in step 1 again, there should now be no occurances. 4. Review the diff for the patch a nd make sure that the change makes sense. 5. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com> I'm not sure of the best way to update the nb-NO files - is this handled by the translation process? (In reply to David Nind from comment #2) > I'm not sure of the best way to update the nb-NO files - is this handled by > the translation process? Yes it is. Thanks for the fix! Created attachment 156463 [details] [review] Bug 34942: Fix typo - 'brower' to 'browser' This fixes a typo in a message used in the advanced cataloguing editor when macros are converted from being stored in the browser to being stored in the database (bug 17268 - Advanced cataloging editor - rancor - macros are lost when browser storage cleared). Test plan: 1. Search for 'brower' in the codebase - there should be one occurance: grep -rn --exclude=*.po brower * 2. Apply the patch. 3. Run the search in step 1 again, there should now be no occurances. 4. Review the diff for the patch a nd make sure that the change makes sense. 5. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 156486 [details] [review] Bug 34942: Fix typo - 'brower' to 'browser' This fixes a typo in a message used in the advanced cataloguing editor when macros are converted from being stored in the browser to being stored in the database (bug 17268 - Advanced cataloging editor - rancor - macros are lost when browser storage cleared). Test plan: 1. Search for 'brower' in the codebase - there should be one occurance: grep -rn --exclude=*.po brower * 2. Apply the patch. 3. Run the search in step 1 again, there should now be no occurances. 4. Review the diff for the patch a nd make sure that the change makes sense. 5. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.05 Nice work everyone! Pushed to oldstable for 22.11.x |