Bug 34954

Summary:	Typo: datexpiry
Product:	Koha	Reporter:	Magnus Enger <magnus>
Component:	Templates	Assignee:	Laura Escamilla <Laura.escamilla>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	trivial
Priority:	P5 - low	CC:	david, fridolin.somers, Laura.escamilla
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00,23.05.06,22.11.12
Circulation function:
Attachments:	Bug 34954: Fixed typo to 'dateexpiry' Bug 34954: Fixed typo to 'dateexpiry' Bug 34954: Fixed typo to 'dateexpiry'

Description Magnus Enger 2023-09-29 06:51:57 UTC

$ grep -rn --exclude=*.po "datexpiry" *
grep: how-to.pl: No such file or directory
koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt:321:                                <option value="">using the datexpiry value in the file, if present</option>
koha-tmpl/intranet-tmpl/prog/nb-NO/modules/tools/import_borrowers.tt:312: <option value="">using the datexpiry value in the file, if present</option>
misc/release_notes/release_notes_18_05_00.html:792:<li><a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145">[20145]</a> borrowers.datexpiry eq '0000-00-00' means expired?</li>
misc/release_notes/release_notes_18_05_00.md:629:- [[20145]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145) borrowers.datexpiry eq '0000-00-00' means expired?
t/db_dependent/Koha/Patrons/Import.t:1204:        "Expiration date is correct with update_dateexpiry = true no dateexpiry in file and update_datexpiryfromtoday false (i.e. use passed dateenrolled) "
t/db_dependent/Koha/Patrons/Import.t:1217:        "Expiration date is correct with update_dateexpiry = true no dateexpiry in file and update_datexpiryfromtoday true "
t/db_dependent/Koha/Patrons/Import.t:1231:        "Expiration date is correct with update_dateexpiry = true no dateexpiry in file and update_datexpiryfromtoday false but no dateenrolled in file (today is used) "

"dateexpiry" is used everywhere else.

Comment 1 Laura Escamilla 2023-10-19 18:31:28 UTC

Created attachment 157476 [details] [review]
Bug 34954: Fixed typo to 'dateexpiry'

To test:

1. In KTD use grep -rn --exclude=*.po "datexpiry" *
2. Notice that the four locations below are showing the typo:
    1. git add koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
    2. git add misc/release_notes/release_notes_18_05_00.html
    3. git add misc/release_notes/release_notes_18_05_00.md
    4. git add t/db_dependent/Koha/Patrons/Import.t
3. Apply patch. Repeat step 1.
4. Notice that no results show. All instances of the typo have been fixed to dateexpiry.
5. Sign off and have a great day :)

Comment 2 David Nind 2023-10-20 16:02:18 UTC

Created attachment 157556 [details] [review]
Bug 34954: Fixed typo to 'dateexpiry'

To test:

1. In KTD use grep -rn --exclude=*.po "datexpiry" *
2. Notice that the four locations below are showing the typo:
    1. git add koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
    2. git add misc/release_notes/release_notes_18_05_00.html
    3. git add misc/release_notes/release_notes_18_05_00.md
    4. git add t/db_dependent/Koha/Patrons/Import.t
3. Apply patch. Repeat step 1.
4. Notice that no results show. All instances of the typo have been fixed to dateexpiry.
5. Sign off and have a great day :)

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Katrin Fischer 2023-10-20 19:59:24 UTC

Created attachment 157568 [details] [review]
Bug 34954: Fixed typo to 'dateexpiry'

To test:

1. In KTD use grep -rn --exclude=*.po "datexpiry" *
2. Notice that the four locations below are showing the typo:
    1. git add koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
    2. git add misc/release_notes/release_notes_18_05_00.html
    3. git add misc/release_notes/release_notes_18_05_00.md
    4. git add t/db_dependent/Koha/Patrons/Import.t
3. Apply patch. Repeat step 1.
4. Notice that no results show. All instances of the typo have been fixed to dateexpiry.
5. Sign off and have a great day :)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2023-10-20 20:29:19 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 5 Fridolin Somers 2023-11-08 07:13:34 UTC

Pushed to 23.05.x for 23.05.06

Comment 6 Matt Blenkinsop 2023-11-13 15:23:19 UTC

Nice work everyone!

Pushed to oldstable for 22.11.x