$ grep -rn --exclude=*.po "datexpiry" * grep: how-to.pl: No such file or directory koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt:321: <option value="">using the datexpiry value in the file, if present</option> koha-tmpl/intranet-tmpl/prog/nb-NO/modules/tools/import_borrowers.tt:312: <option value="">using the datexpiry value in the file, if present</option> misc/release_notes/release_notes_18_05_00.html:792:<li><a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145">[20145]</a> borrowers.datexpiry eq '0000-00-00' means expired?</li> misc/release_notes/release_notes_18_05_00.md:629:- [[20145]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145) borrowers.datexpiry eq '0000-00-00' means expired? t/db_dependent/Koha/Patrons/Import.t:1204: "Expiration date is correct with update_dateexpiry = true no dateexpiry in file and update_datexpiryfromtoday false (i.e. use passed dateenrolled) " t/db_dependent/Koha/Patrons/Import.t:1217: "Expiration date is correct with update_dateexpiry = true no dateexpiry in file and update_datexpiryfromtoday true " t/db_dependent/Koha/Patrons/Import.t:1231: "Expiration date is correct with update_dateexpiry = true no dateexpiry in file and update_datexpiryfromtoday false but no dateenrolled in file (today is used) " "dateexpiry" is used everywhere else.
Created attachment 157476 [details] [review] Bug 34954: Fixed typo to 'dateexpiry' To test: 1. In KTD use grep -rn --exclude=*.po "datexpiry" * 2. Notice that the four locations below are showing the typo: 1. git add koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt 2. git add misc/release_notes/release_notes_18_05_00.html 3. git add misc/release_notes/release_notes_18_05_00.md 4. git add t/db_dependent/Koha/Patrons/Import.t 3. Apply patch. Repeat step 1. 4. Notice that no results show. All instances of the typo have been fixed to dateexpiry. 5. Sign off and have a great day :)
Created attachment 157556 [details] [review] Bug 34954: Fixed typo to 'dateexpiry' To test: 1. In KTD use grep -rn --exclude=*.po "datexpiry" * 2. Notice that the four locations below are showing the typo: 1. git add koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt 2. git add misc/release_notes/release_notes_18_05_00.html 3. git add misc/release_notes/release_notes_18_05_00.md 4. git add t/db_dependent/Koha/Patrons/Import.t 3. Apply patch. Repeat step 1. 4. Notice that no results show. All instances of the typo have been fixed to dateexpiry. 5. Sign off and have a great day :) Signed-off-by: David Nind <david@davidnind.com>
Created attachment 157568 [details] [review] Bug 34954: Fixed typo to 'dateexpiry' To test: 1. In KTD use grep -rn --exclude=*.po "datexpiry" * 2. Notice that the four locations below are showing the typo: 1. git add koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt 2. git add misc/release_notes/release_notes_18_05_00.html 3. git add misc/release_notes/release_notes_18_05_00.md 4. git add t/db_dependent/Koha/Patrons/Import.t 3. Apply patch. Repeat step 1. 4. Notice that no results show. All instances of the typo have been fixed to dateexpiry. 5. Sign off and have a great day :) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.06
Nice work everyone! Pushed to oldstable for 22.11.x