| Summary: | t/Search/buildQuery.t does not do anything with Test::DBIx::Class | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Test Suite | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | fridolin.somers |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.05,22.11.11
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 34336 | ||
| Attachments: |
Bug 34969: Remove unneeded module from buildQuery.t
Bug 34969: Remove unneeded module from buildQuery.t Bug 34969: (QA follow-up) Re-add removed use_ok and can_ok tests |
||
|
Description
Marcel de Rooy
2023-09-30 06:48:21 UTC
Created attachment 156437 [details] [review] Bug 34969: Remove unneeded module from buildQuery.t Test plan: Run t/Search/buildQuery.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Trivial: Self signoff Created attachment 156491 [details] [review] Bug 34969: Remove unneeded module from buildQuery.t Test plan: Run t/Search/buildQuery.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 156492 [details] [review] Bug 34969: (QA follow-up) Re-add removed use_ok and can_ok tests No need to remove them for removing Test::DBIx::Class dependency. Tests still pass. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Marcel commented on the removed tests on another bug - removing my follo-up: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34968#c4 Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.05 Nice work everyone! Pushed to oldstable for 22.11.x |