| Summary: | Allow to delete multiple patron lists at once | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Salah Ghedda <salah.ghedda> |
| Component: | Tools | Assignee: | Salah Ghedda <salah.ghedda> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, clackman, david, fridolin.somers, jonathan.druart, kyle, phan-tung.bui, philippe.blouin |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29830 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Caroline Cyr La Rose | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/781 |
| Text to go in the release notes: |
This enhancement enables selecting and deleting multiple patron lists at once, instead of having to delete patron lists one at a time.
|
Version(s) released in: |
23.11.00
|
| Circulation function: | |||
| Attachments: |
Bug 34977: The "Patron Lists" only allows deleting one list at a time
Bug 34977: The "Patron Lists" only allows deleting one list at a time Bug 34977: The "Patron Lists" only allows deleting one list at a time Bug 34977: The "Patron Lists" only allows deleting one list at a time Bug 34977: (QA follow-up) Tidy code Bug 34977: The "Patron Lists" only allows deleting one list at a time Bug 34977: (QA follow-up) Tidy code |
||
|
Description
Salah Ghedda
2023-10-03 15:08:35 UTC
Created attachment 156553 [details] [review] Bug 34977: The "Patron Lists" only allows deleting one list at a time In the patrons lists, it's only possible to delete on list at a time. This patch add the possibility to select lists and delete them at once. TEST PLAN 1. Apply the patch. 2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete. 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. Created attachment 156554 [details] [review] Bug 34977: The "Patron Lists" only allows deleting one list at a time In the patrons lists, it's only possible to delete one list at a time. This patch add the possibility to select lists and delete them at once. TEST PLAN 1. Apply the patch. 2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete. 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. Created attachment 156562 [details] [review] Bug 34977: The "Patron Lists" only allows deleting one list at a time In the patrons lists, it's only possible to delete on list at a time. This patch add the possibility to select lists and delete them at once. TEST PLAN 1. Apply the patch. 2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete. 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. Signed-off-by: David Nind <david@davidnind.com> Created attachment 158349 [details] [review] Bug 34977: The "Patron Lists" only allows deleting one list at a time In the patrons lists, it's only possible to delete on list at a time. This patch add the possibility to select lists and delete them at once. TEST PLAN 1. Apply the patch. 2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete. 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 158350 [details] [review] Bug 34977: (QA follow-up) Tidy code Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Would be nice if there was a select all button, but not a blocker Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x Created attachment 159483 [details] [review] Bug 34977: The "Patron Lists" only allows deleting one list at a time In the patrons lists, it's only possible to delete on list at a time. This patch add the possibility to select lists and delete them at once. TEST PLAN 1. Apply the patch. 2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete. 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 159484 [details] [review] Bug 34977: (QA follow-up) Tidy code Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased - return confirmDelete( _("Are you sure you want to delete the list %s?").format(list) );
+ return confirmDelete( _("Are you sure you want to delete the list %s?").format(list));
This change is wrong, unnecessary and causes conflict! Please avoid them and catch them before push!
Bug 34977 prevented users from deleting multiple patron lists from the 2nd page onwards. Please check bug 36132 for more details |