Bug 36132 - Allow users to delete multiple patron_lists at once on any page
Summary: Allow users to delete multiple patron_lists at once on any page
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Phan Tung Bui
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-19 18:39 UTC by Phan Tung Bui
Modified: 2024-08-26 07:50 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes patron lists so that when there are more than 20 lists, the lists on the next pages can be deleted. Previously, you were only able to delete the lists on the first page.
Version(s) released in:
Circulation function:


Attachments
Bug 36132: Allow to delete multiple patron lists on any page (6.66 KB, patch)
2024-02-19 19:54 UTC, Phan Tung Bui
Details | Diff | Splinter Review
Bug 36132: Allow to delete multiple patron lists on any page (6.71 KB, patch)
2024-04-24 20:04 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 36132: Allow to delete multiple patron lists on any page (6.77 KB, patch)
2024-07-19 13:37 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 36132: Allow to delete multiple patron lists on any page (1.38 KB, patch)
2024-08-12 19:17 UTC, Hammat wele
Details | Diff | Splinter Review
Bug 36132: Allow to delete multiple patron lists on any page (1.43 KB, patch)
2024-08-26 06:10 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Phan Tung Bui 2024-02-19 18:39:40 UTC
Bug 34977 prevented users from deleting multiple patron lists from the 2nd page onwards. This patch resolves the issue
Comment 1 Phan Tung Bui 2024-02-19 19:54:56 UTC
Created attachment 162283 [details] [review]
Bug 36132: Allow to delete multiple patron lists on any page

Plan test : 
1. Apply the patch.
2. Create at least 22 patron lists (Navigate to Tools > Patron lists > New patron list).
3. Select the lists you want to delete on the 2nd page
4. Click the "Delete selected lists" button.
5. Confirm that the selected lists have been deleted.
6. Ensure that the button cannot be used if no list is selected.
Comment 2 Roman Dolny 2024-04-24 20:04:21 UTC
Created attachment 165486 [details] [review]
Bug 36132: Allow to delete multiple patron lists on any page

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Kyle M Hall (khall) 2024-07-19 13:37:43 UTC
Created attachment 169223 [details] [review]
Bug 36132: Allow to delete multiple patron lists on any page

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-08-02 16:20:58 UTC
This one doesn't look correct to me:

 [% USE raw %]
 [% USE Asset %]
-[% PROCESS 'i18n.inc' %]
 [% SET footerjs = 1 %]
 [% INCLUDE 'doc-head-open.inc' %]
-<title>[% FILTER collapse %]
-    [% t("Patron lists") | html %] &rsaquo;
-    [% t("Tools") | html %] &rsaquo;
-    [% t("Koha") | html %]
-[% END %]</title>
+<title>Patron lists &rsaquo; Tools &rsaquo; Koha</title>
 [% INCLUDE 'doc-head-close.inc' %]
 [% INCLUDE 'greybox.inc' %]
 </head>
@@ -32,7 +27,6 @@
     <div class="row">
         <div class="col-sm-10 col-sm-push-2">
             <main>
-                [% INCLUDE 'messages.inc' %]


These undoes other changes, like the re-working of the breadcrumbs. Please also check the other removals carefully.
Comment 5 Katrin Fischer 2024-08-02 16:22:05 UTC
Also this appears unrelated to what this patch advertises:

-        <h1>Patron lists</h1>
+        <h1>Your patron lists </h1>

Please check if this is correct, patron lists can now be shared, so this might also be undoing another intentional change.
Comment 6 Katrin Fischer 2024-08-07 13:57:22 UTC
To hopefully avoid confusion: I had forgotten to remove this from my branch after testing and it was accidentally pushed. Reverted now waiting for a clean patch.
Comment 7 Hammat wele 2024-08-12 19:17:58 UTC
Created attachment 170237 [details] [review]
Bug 36132: Allow to delete multiple patron lists on any page

Plan test :
1. Apply the patch.
2. Create at least 22 patron lists (Navigate to Tools > Patron lists > New patron list).
3. Select the lists you want to delete on the 2nd page
4. Click the "Delete selected lists" button.
5. Confirm that the selected lists have been deleted.
6. Ensure that the button cannot be used if no list is selected.
Comment 8 David Nind 2024-08-26 06:10:39 UTC
Created attachment 170699 [details] [review]
Bug 36132: Allow to delete multiple patron lists on any page

Plan test :
1. Apply the patch.
2. Create at least 22 patron lists (Navigate to Tools > Patron lists > New patron list).
3. Select the lists you want to delete on the 2nd page
4. Click the "Delete selected lists" button.
5. Confirm that the selected lists have been deleted.
6. Ensure that the button cannot be used if no list is selected.

Signed-off-by: David Nind <david@davidnind.com>