|
Description
Blou
2023-10-11 15:51:05 UTC
Created attachment 156852 [details] [review] Bug 35033: Add a validation for biblioitems in about/system information In the About section, under the System information tab, we get validation between issues, borrowers, biblio, items, reserves tables, and their deleted/old counterpart. But there's no validation for biblioitems. This patch will simply add the same test (and display) as the others, but for biblioitems. Testing 0) Create a simple biblio entry through cataloguing. Note the biblioitemnumber created. 1) Insert a dummy entry in deletedbiblioitem using the biblioitemnumber. An simple SQL will do insert into deletedbiblioitems select * from biblioitems where biblioitemnumber = GIVENbin; 2) Go to about, see there's no warning in systeminformation. 3) apply the patch, validate that an error appears. Created attachment 156853 [details] [review] Bug 35033: Add a validation for biblioitems in about/system information In the About section, under the System information tab, we get validation between issues, borrowers, biblio, items, reserves tables, and their deleted/old counterpart. But there's no validation for biblioitems. This patch will simply add the same test (and display) as the others, but for biblioitems. Testing 0) Create a simple biblio entry through cataloguing. Note the biblioitemnumber created. 1) Insert a dummy entry in deletedbiblioitem using the biblioitemnumber. An simple SQL will do insert into deletedbiblioitems select * from biblioitems where biblioitemnumber = GIVENbin; 2) Go to about, see there's no warning in systeminformation. 3) apply the patch, validate that an error appears. Created attachment 157621 [details] [review] Bug 35033: Add a validation for biblioitems in about/system information In the About section, under the System information tab, we get validation between issues, borrowers, biblio, items, reserves tables, and their deleted/old counterpart. But there's no validation for biblioitems. This patch will simply add the same test (and display) as the others, but for biblioitems. Testing 0) Create a simple biblio entry through cataloguing. Note the biblioitemnumber created. 1) Insert a dummy entry in deletedbiblioitem using the biblioitemnumber. An simple SQL will do insert into deletedbiblioitems select * from biblioitems where biblioitemnumber = GIVENbin; 2) Go to about, see there's no warning in systeminformation. 3) apply the patch, validate that an error appears. Signed-off-by: David Nind <david@davidnind.com> Created attachment 158098 [details] [review] Bug 35033: Add a validation for biblioitems in about/system information In the About section, under the System information tab, we get validation between issues, borrowers, biblio, items, reserves tables, and their deleted/old counterpart. But there's no validation for biblioitems. This patch will simply add the same test (and display) as the others, but for biblioitems. Testing 0) Create a simple biblio entry through cataloguing. Note the biblioitemnumber created. 1) Insert a dummy entry in deletedbiblioitem using the biblioitemnumber. An simple SQL will do insert into deletedbiblioitems select * from biblioitems where biblioitemnumber = GIVENbin; 2) Go to about, see there's no warning in systeminformation. 3) apply the patch, validate that an error appears. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Created attachment 158099 [details] [review] Bug 35033: (QA follow-up): tidy up code Works, makes sense, QA script happy, code looks good, passing QA :) Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.06 Nice work everyone! Pushed to oldstable for 22.11.x |