Bug 35033 added a check for auto increment problems related to biblioitems. The code looks like this: my $biblioitems = $dbh->selectall_arrayref( q|select bi.biblioitemnumber from biblioitems bi join deletedbiblioitems dbi on bi.biblionumber=dbi.biblionumber|, { Slice => {} } ); It compares biblioitems and deletedbiblioitems, which makes sense. But the template that displays the results look like this: [% IF ai_biblioitems %] <h4>Bibliographic records</h4> <p>The following IDs exist in both tables [% "biblio" | $HtmlTags tag="strong" %] and [% "deletedbiblioitems" | $HtmlTags tag="strong" %]:</p> <p> [% FOR b IN ai_biblioitems %] [% b.biblioitemnumber | html %] [% UNLESS loop.last %], [% END %] [% END %] </p> [% END %] The problem is this: The following IDs exist in both tables [% "biblio" | $HtmlTags tag="strong" %] and [% "deletedbiblioitems" | $HtmlTags tag="strong" %] It says "biblio and deletedbiblioitems", when it should say "biblioitems and deletedbiblioitems".
Created attachment 175165 [details] [review] Bug 38617: Fix warning about auto increment and biblioitems To reproduce: - Delete a bibliographic, noting the biblionumber (let's call it X) - Run this in the database: UPDATE deletedbiblioitems SET biblionumber = X; - Go to About Koha > System information - Notice the warning compares two tables that are not equivalent: "The following IDs exist in both tables biblio and deletedbiblioitems" To test: - Apply the patch - Reload the System information - The warning should now read: "The following IDs exist in both tables biblioitems and deletedbiblioitems"