Description
Martin Renvoize (ashimema)
2023-10-17 08:47:25 UTC
Created attachment 157227 [details] [review] Bug 35074: Add patron relationship alias This patch adds the 'patron' relationship alias to the Acountline DBIx::Class schema. Created attachment 157228 [details] [review] Bug 35074: Add support for category_code to writeoff_debts This patch adds support for passing category_code as a limiter for the writeoff_debts script. Created attachment 157860 [details] [review] Bug 35074: Add patron relationship alias This patch adds the 'patron' relationship alias to the Acountline DBIx::Class schema. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 157861 [details] [review] Bug 35074: Add support for category_code to writeoff_debts This patch adds support for passing category_code as a limiter for the writeoff_debts script. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> WARN Koha/Schema/Result/Accountline.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 142, now: 151) WARN misc/cronjobs/writeoff_debts.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 17, now: 18) Koha/Account/Line.pm | 2 +- Koha/Schema/Result/Accountline.pm | 20 ++++++++++++++++++++ Please dont mix that. Created attachment 157981 [details] [review] Bug 35074: Add patron relationship alias This patch adds the 'patron' relationship alias to the Acountline DBIx::Class schema. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 157982 [details] [review] Bug 35074: Use patron relationship alias This patch updates the existing Koha::Account::Line->patron accessor to use the new aliased 'patron' relation in the schema class Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 157983 [details] [review] Bug 35074: Add support for category_code to writeoff_debts This patch adds support for passing category_code as a limiter for the writeoff_debts script. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Patch split and SO cloned across.. All patches re-tidied and QA script no longer complaining. Created attachment 158057 [details] [review] Bug 35074: Add patron relationship alias This patch adds the 'patron' relationship alias to the Acountline DBIx::Class schema. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 158058 [details] [review] Bug 35074: Use patron relationship alias This patch updates the existing Koha::Account::Line->patron accessor to use the new aliased 'patron' relation in the schema class Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 158059 [details] [review] Bug 35074: Add support for category_code to writeoff_debts This patch adds support for passing category_code as a limiter for the writeoff_debts script. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |