Created attachment 161764 [details] [review] Bug 35996: Make it clear that --category-code can not be used alone This patch adds a clarification to writeoff_debts.pl to make it clear that --category-code can't be used as the only filter when running the script. If this is the case, the script just displays the help menu as it is expecting one of the other filters Test plan: 1) Run perl misc/cronjobs/writeoff_debts.pl --category-code TEST --confirm 2) Observe that the help menu is displayed instead of running the script 3) Check the help menu for the text added in this patch
Created attachment 161770 [details] [review] Bug 35996: Make it clear that --category-code can not be used alone This patch adds a clarification to writeoff_debts.pl to make it clear that --category-code can't be used as the only filter when running the script. If this is the case, the script just displays the help menu as it is expecting one of the other filters Test plan: 1) Run perl misc/cronjobs/writeoff_debts.pl --category-code TEST --confirm 2) Observe that the help menu is displayed instead of running the script 3) Check the help menu for the text added in this patch Signed-off-by: David Nind <david@davidnind.com>
I decided in the end that you were probably right in the first place Matt, and that it could be a useful option to allow category only filtering. In bug 34077 we add the category parameter to the initial check line, so maybe we just need that one instead of this. I'll leave this open for now to get other opinions.
Created attachment 164820 [details] [review] Bug 35996: Make it clear that --category-code can not be used alone This patch adds a clarification to writeoff_debts.pl to make it clear that --category-code can't be used as the only filter when running the script. If this is the case, the script just displays the help menu as it is expecting one of the other filters Test plan: 1) Run perl misc/cronjobs/writeoff_debts.pl --category-code TEST --confirm 2) Observe that the help menu is displayed instead of running the script 3) Check the help menu for the text added in this patch WNC amended patch - added same warning in the option section Signed-off-by: David Nind <david@davidnind.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Enhancement will not be backported to 23.05.x