Summary: | Invalid HTML in OpacShowSavings system preference | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, matt.blenkinsop, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.06
|
|
Circulation function: | |||
Bug Depends on: | 31051 | ||
Bug Blocks: | |||
Attachments: |
Bug 35078: Remove invalid HTML from OpacShowSavings system preference
Bug 35078: Remove invalid HTML from OpacShowSavings system preference Bug 35078: Remove invalid HTML from OpacShowSavings system preference |
Description
Caroline Cyr La Rose
2023-10-17 13:48:27 UTC
Created attachment 157251 [details] [review] Bug 35078: Remove invalid HTML from OpacShowSavings system preference The options defined for the OpacShowSavings system preference contain HTML: "on patron's checkout history page (the system preference <em>opacreadinghistory</em> must be enabled)". This text ends up in an <option> tag, and even though the form is rendered using the multiple-select plugin the HTML still won't render and should be removed. To test, apply the patch and restart all. - Go to Administration -> System preferences and search for "OpacShowSavings" - Check the dropdown of options on the preference. The system preference names referred to should now be single-quoted instead of wrapped in visible <em> tags. - Confirm that the preference still works correctly. Created attachment 157252 [details] [review] Bug 35078: Remove invalid HTML from OpacShowSavings system preference The options defined for the OpacShowSavings system preference contain HTML: "on patron's checkout history page (the system preference <em>opacreadinghistory</em> must be enabled)". This text ends up in an <option> tag, and even though the form is rendered using the multiple-select plugin the HTML still won't render and should be removed. To test, apply the patch and restart all. - Go to Administration -> System preferences and search for "OpacShowSavings" - Check the dropdown of options on the preference. The system preference names referred to should now be single-quoted instead of wrapped in visible <em> tags. - Confirm that the preference still works correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Also tested the translation and it looks good! Created attachment 157366 [details] [review] Bug 35078: Remove invalid HTML from OpacShowSavings system preference The options defined for the OpacShowSavings system preference contain HTML: "on patron's checkout history page (the system preference <em>opacreadinghistory</em> must be enabled)". This text ends up in an <option> tag, and even though the form is rendered using the multiple-select plugin the HTML still won't render and should be removed. To test, apply the patch and restart all. - Go to Administration -> System preferences and search for "OpacShowSavings" - Check the dropdown of options on the preference. The system preference names referred to should now be single-quoted instead of wrapped in visible <em> tags. - Confirm that the preference still works correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works, makes sense, QA script happy, code looks good, passing QA :) Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.06 Dependency missing for 22.11.x - not backporting |