In the OpacShowSavings system preference, there are some <em> tags that are shown rather than making the text italic. To test: 1. Go to Administration > System preferences 2. Search for OPACShowSavings 3. Open the drop-down menu --> The <em> tags are displayed
Created attachment 157251 [details] [review] Bug 35078: Remove invalid HTML from OpacShowSavings system preference The options defined for the OpacShowSavings system preference contain HTML: "on patron's checkout history page (the system preference <em>opacreadinghistory</em> must be enabled)". This text ends up in an <option> tag, and even though the form is rendered using the multiple-select plugin the HTML still won't render and should be removed. To test, apply the patch and restart all. - Go to Administration -> System preferences and search for "OpacShowSavings" - Check the dropdown of options on the preference. The system preference names referred to should now be single-quoted instead of wrapped in visible <em> tags. - Confirm that the preference still works correctly.
Created attachment 157252 [details] [review] Bug 35078: Remove invalid HTML from OpacShowSavings system preference The options defined for the OpacShowSavings system preference contain HTML: "on patron's checkout history page (the system preference <em>opacreadinghistory</em> must be enabled)". This text ends up in an <option> tag, and even though the form is rendered using the multiple-select plugin the HTML still won't render and should be removed. To test, apply the patch and restart all. - Go to Administration -> System preferences and search for "OpacShowSavings" - Check the dropdown of options on the preference. The system preference names referred to should now be single-quoted instead of wrapped in visible <em> tags. - Confirm that the preference still works correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Also tested the translation and it looks good!
Created attachment 157366 [details] [review] Bug 35078: Remove invalid HTML from OpacShowSavings system preference The options defined for the OpacShowSavings system preference contain HTML: "on patron's checkout history page (the system preference <em>opacreadinghistory</em> must be enabled)". This text ends up in an <option> tag, and even though the form is rendered using the multiple-select plugin the HTML still won't render and should be removed. To test, apply the patch and restart all. - Go to Administration -> System preferences and search for "OpacShowSavings" - Check the dropdown of options on the preference. The system preference names referred to should now be single-quoted instead of wrapped in visible <em> tags. - Confirm that the preference still works correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, makes sense, QA script happy, code looks good, passing QA :)
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.06
Dependency missing for 22.11.x - not backporting