Bug 35097

Summary: Use country-list.inc to display choices for UsageStatsCountry preference
Product: Koha Reporter: Owen Leonard <oleonard>
Component: System AdministrationAssignee: Owen Leonard <oleonard>
Status: Needs documenting --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, gmcharlt, testopia
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:
Bug Depends on: 35091    
Bug Blocks:    
Attachments: Bug 35097: Use country-list.inc to display choices for UsageStatsCountry preference
Bug 35097: Use country-list.inc to display choices for UsageStatsCountry preference
Bug 35097: Use country-list.inc to display choices for UsageStatsCountry preference

Description Owen Leonard 2023-10-18 16:07:57 UTC
The usage statistics page uses an include file, country-list.inc, to display a dropdown of countries to choose from.

The same list is duplicated in admin.pref for the UsageStatsCountry preference.

We should use the same include file for both interfaces, to reduce redundancy in code and in the translation process.
Comment 1 Owen Leonard 2023-10-18 16:16:37 UTC
Created attachment 157340 [details] [review]
Bug 35097: Use country-list.inc to display choices for UsageStatsCountry preference

This patch updates the system preferences interface so that it uses
country-list.inc for the selection of countries for the
UsageStatsCountry preference.

To test, apply the patch and restart services.

- Go to Administration -> System preferences and search for
  "UsageStatsCountry"
- The dropdown of countries should look correct.
- Select a country, save, and confirm that your choice is saved
  correctly.
Comment 2 David Nind 2023-10-19 12:21:42 UTC
Created attachment 157429 [details] [review]
Bug 35097: Use country-list.inc to display choices for UsageStatsCountry preference

This patch updates the system preferences interface so that it uses
country-list.inc for the selection of countries for the
UsageStatsCountry preference.

To test, apply the patch and restart services.

- Go to Administration -> System preferences and search for
  "UsageStatsCountry"
- The dropdown of countries should look correct.
- Select a country, save, and confirm that your choice is saved
  correctly.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2023-10-20 20:22:18 UTC
Currently blocked by the dependency bug.
Comment 4 Martin Renvoize (ashimema) 2024-01-24 14:35:51 UTC
Created attachment 161338 [details] [review]
Bug 35097: Use country-list.inc to display choices for UsageStatsCountry preference

This patch updates the system preferences interface so that it uses
country-list.inc for the selection of countries for the
UsageStatsCountry preference.

To test, apply the patch and restart services.

- Go to Administration -> System preferences and search for
  "UsageStatsCountry"
- The dropdown of countries should look correct.
- Select a country, save, and confirm that your choice is saved
  correctly.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Katrin Fischer 2024-03-22 14:09:12 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-05-23 07:45:07 UTC
Not backported to 23.11.x