Bug 35097 - Use country-list.inc to display choices for UsageStatsCountry preference
Summary: Use country-list.inc to display choices for UsageStatsCountry preference
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 35091
Blocks:
  Show dependency treegraph
 
Reported: 2023-10-18 16:07 UTC by Owen Leonard
Modified: 2024-01-24 14:36 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35097: Use country-list.inc to display choices for UsageStatsCountry preference (11.77 KB, patch)
2023-10-18 16:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35097: Use country-list.inc to display choices for UsageStatsCountry preference (11.82 KB, patch)
2023-10-19 12:21 UTC, David Nind
Details | Diff | Splinter Review
Bug 35097: Use country-list.inc to display choices for UsageStatsCountry preference (11.89 KB, patch)
2024-01-24 14:35 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-10-18 16:07:57 UTC
The usage statistics page uses an include file, country-list.inc, to display a dropdown of countries to choose from.

The same list is duplicated in admin.pref for the UsageStatsCountry preference.

We should use the same include file for both interfaces, to reduce redundancy in code and in the translation process.
Comment 1 Owen Leonard 2023-10-18 16:16:37 UTC
Created attachment 157340 [details] [review]
Bug 35097: Use country-list.inc to display choices for UsageStatsCountry preference

This patch updates the system preferences interface so that it uses
country-list.inc for the selection of countries for the
UsageStatsCountry preference.

To test, apply the patch and restart services.

- Go to Administration -> System preferences and search for
  "UsageStatsCountry"
- The dropdown of countries should look correct.
- Select a country, save, and confirm that your choice is saved
  correctly.
Comment 2 David Nind 2023-10-19 12:21:42 UTC
Created attachment 157429 [details] [review]
Bug 35097: Use country-list.inc to display choices for UsageStatsCountry preference

This patch updates the system preferences interface so that it uses
country-list.inc for the selection of countries for the
UsageStatsCountry preference.

To test, apply the patch and restart services.

- Go to Administration -> System preferences and search for
  "UsageStatsCountry"
- The dropdown of countries should look correct.
- Select a country, save, and confirm that your choice is saved
  correctly.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2023-10-20 20:22:18 UTC
Currently blocked by the dependency bug.
Comment 4 Martin Renvoize 2024-01-24 14:35:51 UTC
Created attachment 161338 [details] [review]
Bug 35097: Use country-list.inc to display choices for UsageStatsCountry preference

This patch updates the system preferences interface so that it uses
country-list.inc for the selection of countries for the
UsageStatsCountry preference.

To test, apply the patch and restart services.

- Go to Administration -> System preferences and search for
  "UsageStatsCountry"
- The dropdown of countries should look correct.
- Select a country, save, and confirm that your choice is saved
  correctly.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>