Bug 35108

Summary: ILL - "Manage request" page is too loaded
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: ILLAssignee: Pedro Amorim <pedro.amorim>
Status: Pushed to main --- QA Contact: Martin Renvoize <martin.renvoize>
Severity: enhancement    
Priority: P5 - low CC: david, katrin.fischer, magnus, martin.renvoize, pedro.amorim, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
This enhancement hides option fields that are empty when displaying ILL requests.
Version(s) released in:
24.05.00
Bug Depends on: 35107    
Bug Blocks:    
Attachments: Bug 35108: Hide optionally empty fields label entries, these are:
Bug 35108: Move request id to page header
Bug 35108: Hide optionally empty fields label entries, these are:
Bug 35108: Move request id to page header
Bug 35108: Hide optionally empty fields label entries, these are:
Bug 35108: Move request id to page header
Bug 35108: Hide optionally empty fields label entries, these are:
Bug 35108: Move request id to page header
Bug 35108: Hide empty fields on ILL manage request page
Bug 35108: Move request id to page header
Bug 35108: Hide empty fields on ILL manage request page

Description Pedro Amorim 2023-10-19 14:17:22 UTC
A simple ILL request that has a lot of fields empty is still presented with a very long "Manage request" page. We could do with lighten the page a bit.
Comment 1 Pedro Amorim 2023-10-19 14:23:22 UTC Comment hidden (obsolete)
Comment 2 Pedro Amorim 2023-10-19 14:23:53 UTC
Created attachment 157463 [details] [review]
Bug 35108: Move request id to page header

Redundant information, can be moved to header for more visibility and less horizontal length
Comment 3 Pedro Amorim 2023-10-19 14:23:56 UTC
Created attachment 157464 [details] [review]
Bug 35108: Hide optionally empty fields label entries, these are:

orderid, biblio_id, batch already was the case, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac

Test plan, k-t-d:
1) Install FreeForm and BLDSS backends, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh)
2) Create a new FreeForm request, visit:
/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm
5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'.
6) Notice how there is a lot of unnecessary empty field entries
7) Apply patch, restart plack (koha-plack --restart kohadev)
8) Refresh the page, notice all the empty fields entries are no longer displayed
Comment 4 Pedro Amorim 2023-12-07 16:52:31 UTC
Created attachment 159657 [details] [review]
Bug 35108: Move request id to page header

Redundant information, can be moved to header for more visibility and less horizontal length
Comment 5 Pedro Amorim 2023-12-07 16:52:33 UTC
Created attachment 159658 [details] [review]
Bug 35108: Hide optionally empty fields label entries, these are:

orderid, biblio_id, batch already was the case, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac

Test plan, k-t-d:
1) Install FreeForm and BLDSS backends, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh)
2) Create a new FreeForm request, visit:
/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm
5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'.
6) Notice how there is a lot of unnecessary empty field entries
7) Apply patch, restart plack (koha-plack --restart kohadev)
8) Refresh the page, notice all the empty fields entries are no longer displayed
Comment 6 David Nind 2023-12-08 21:19:30 UTC
Created attachment 159688 [details] [review]
Bug 35108: Move request id to page header

Redundant information, can be moved to header for more visibility and less horizontal length

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2023-12-08 21:19:33 UTC
Created attachment 159689 [details] [review]
Bug 35108: Hide optionally empty fields label entries, these are:

orderid, biblio_id, batch already was the case, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac

Test plan, k-t-d:
1) Install FreeForm and BLDSS backends, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh)
2) Create a new FreeForm request, visit:
/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm
5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'.
6) Notice how there is a lot of unnecessary empty field entries
7) Apply patch, restart plack (koha-plack --restart kohadev)
8) Refresh the page, notice all the empty fields entries are no longer displayed

Signed-off-by: David Nind <david@davidnind.com>
Comment 8 Martin Renvoize 2023-12-12 16:45:47 UTC
Created attachment 159752 [details] [review]
Bug 35108: Move request id to page header

Redundant information, can be moved to header for more visibility and less horizontal length

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Martin Renvoize 2023-12-12 16:45:49 UTC
Created attachment 159753 [details] [review]
Bug 35108: Hide empty fields on ILL manage request page

Optionally empty fields are: orderid, biblio_id, batch,
type, type_disclaimer_value, type_disclaimer_date, cost,
price_paid, notesstaff, notesopac.

Test plan, k-t-d:
1) Install FreeForm and BLDSS backends, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh)
2) Create a new FreeForm request, visit:
/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm
5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'.
6) Notice how there is a lot of unnecessary empty field entries
7) Apply patch, restart plack (koha-plack --restart kohadev)
8) Refresh the page, notice all the empty fields entries are no longer displayed

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize 2023-12-12 16:47:50 UTC
Simple trivial patch to improve display.. Passing QA, but the dependency still needs an QA stamp from someone else.

I'll pass then mark as blocked whilst we wait for the dependency.
Comment 11 Katrin Fischer 2024-04-18 15:29:28 UTC
Hi Pedro, should be an easy rebase, but I want to keep moving right now - can you please take care of it?
Comment 12 Pedro Amorim 2024-04-18 15:46:35 UTC
Created attachment 165136 [details] [review]
Bug 35108: Move request id to page header

Redundant information, can be moved to header for more visibility and less horizontal length

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 13 Pedro Amorim 2024-04-18 15:46:40 UTC
Created attachment 165137 [details] [review]
Bug 35108: Hide empty fields on ILL manage request page

Optionally empty fields are: orderid, biblio_id, batch,
type, type_disclaimer_value, type_disclaimer_date, cost,
price_paid, notesstaff, notesopac.

Test plan, k-t-d:
1) Install FreeForm and BLDSS backends, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh)
2) Create a new FreeForm request, visit:
/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm
5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'.
6) Notice how there is a lot of unnecessary empty field entries
7) Apply patch, restart plack (koha-plack --restart kohadev)
8) Refresh the page, notice all the empty fields entries are no longer displayed

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 14 Katrin Fischer 2024-04-18 15:59:09 UTC
This resolve at least a part of my Bug 36401 - Yay! :)
Comment 15 Katrin Fischer 2024-04-19 16:07:27 UTC
Pushed for 24.05!

Well done everyone, thank you!