Summary: | Authorities editor with JS error when only one tab | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Templates | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | Pushed to oldstable --- | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | major | ||
Priority: | P5 - low | CC: | alejojanin, david |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.05,22.11.12
|
|
Bug Depends on: | 33524, 34251 | ||
Bug Blocks: | |||
Attachments: |
Bug 35110: Authorities editor with JS error when only one tab
Bug 35110: (follow-up) Fix comment in addbiblio.tt Bug 35110: Authorities editor with JS error when only one tab Bug 35110: (follow-up) Fix comment in addbiblio.tt Bug 35110: Authorities editor with JS error when only one tab Bug 35110: (follow-up) Fix comment in addbiblio.tt |
Description
Fridolin Somers
2023-10-19 19:04:05 UTC
... Maybe selectTab() should be moved to cataloging.js ... Also we may have use TT syntax like in tabs build : [% IF BIG_LOOP.size <= 1 %] But JS does the job ;) Created attachment 157477 [details] [review] Bug 35110: Authorities editor with JS error when only one tab Exactly like Bug 34251 for biblios : When using the an authorities framework with all fields in the same tab, there is thrown a JS error in selectTab( "#tab0XX_panel" ); This is because no nav tabs are build in authorities/authorities.tt as BIG_LOOP has a length(size) of 1 Test plan : 1) Edit an authority framework, for example 'Meeting Name', to set all sufields in tab 0 You may use SQL : UPDATE auth_subfield_structure SET tab=0 WHERE authtypecode='MEETI_NAME' Don't forget to restart memcached 2) Go to 'Authorities' 3) Click on 'New authority' then 'Meeting Name' 4) Check you don't see any JavaScript error 5) Check you can save Created attachment 157478 [details] [review] Bug 35110: (follow-up) Fix comment in addbiblio.tt Change comment in addbiblio.tt since any biblio framework may use only one tab. Also fixes indenting using 4 spaces. Created attachment 157554 [details] [review] Bug 35110: Authorities editor with JS error when only one tab Exactly like Bug 34251 for biblios : When using the an authorities framework with all fields in the same tab, there is thrown a JS error in selectTab( "#tab0XX_panel" ); This is because no nav tabs are build in authorities/authorities.tt as BIG_LOOP has a length(size) of 1 Test plan : 1) Edit an authority framework, for example 'Meeting Name', to set all sufields in tab 0 You may use SQL : UPDATE auth_subfield_structure SET tab=0 WHERE authtypecode='MEETI_NAME' Don't forget to restart memcached 2) Go to 'Authorities' 3) Click on 'New authority' then 'Meeting Name' 4) Check you don't see any JavaScript error 5) Check you can save Signed-off-by: David Nind <david@davidnind.com> Created attachment 157555 [details] [review] Bug 35110: (follow-up) Fix comment in addbiblio.tt Change comment in addbiblio.tt since any biblio framework may use only one tab. Also fixes indenting using 4 spaces. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. Issue fixed! 2. Noticed error in the console "downloadable font: Glyph bbox was incorrect" - there is a bug for this already - bug 34973 Created attachment 157566 [details] [review] Bug 35110: Authorities editor with JS error when only one tab Exactly like Bug 34251 for biblios : When using the an authorities framework with all fields in the same tab, there is thrown a JS error in selectTab( "#tab0XX_panel" ); This is because no nav tabs are build in authorities/authorities.tt as BIG_LOOP has a length(size) of 1 Test plan : 1) Edit an authority framework, for example 'Meeting Name', to set all sufields in tab 0 You may use SQL : UPDATE auth_subfield_structure SET tab=0 WHERE authtypecode='MEETI_NAME' Don't forget to restart memcached 2) Go to 'Authorities' 3) Click on 'New authority' then 'Meeting Name' 4) Check you don't see any JavaScript error 5) Check you can save Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 157567 [details] [review] Bug 35110: (follow-up) Fix comment in addbiblio.tt Change comment in addbiblio.tt since any biblio framework may use only one tab. Also fixes indenting using 4 spaces. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.05 Nice work everyone! Pushed to oldstable for 22.11.x *** Bug 34541 has been marked as a duplicate of this bug. *** |