Bug 34251 - MARC editor with JS error when using fast add framework
Summary: MARC editor with JS error when using fast add framework
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jan Kissig
QA Contact: Katrin Fischer
URL:
Keywords:
: 34329 (view as bug list)
Depends on:
Blocks: 35110
  Show dependency tree / graph
 
Reported: 2023-07-11 12:46 UTC by Jan Kissig
Modified: 2024-07-04 20:37 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08
Circulation function:

Attachments
Bug_34251 When using the fast add framework in addbiblio.pl there is thrown a JS error in selectTab( "#tab0XX_panel" ); (1.50 KB, patch)
2023-07-12 08:47 UTC, Jan Kissig 		Details | Diff | Splinter Review
Bug 34251: When using the fast add framework in addbiblio.pl there is thrown a JS error in selectTab( "#tab0XX_panel" ); (1.55 KB, patch)
2023-07-12 11:18 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 34251: When using the fast add framework in addbiblio.pl there is thrown a JS error in selectTab( "#tab0XX_panel" ); (1.61 KB, patch)
2023-07-16 11:45 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Kissig 2023-07-11 12:46:07 UTC 
When using the fast add framework in addbiblio.pl there is thrown a JS error in selectTab( "#tab0XX_panel" );

This is because no nav tabs are build in addbiblio.tt as BIG_LOOP has a length(size) of 1

To test:

1) go to More>Cataloging
2) click +New record
3) Click Settings> Fast add framework
4) take a look on console
5) try selecting a different framework now,
Comment 1 Jan Kissig 2023-07-12 08:47:09 UTC 
Created attachment 153344 [details] [review]
Bug_34251 When using the fast add framework in addbiblio.pl there is thrown a JS error in selectTab( "#tab0XX_panel" );

This is because no nav tabs are build in addbiblio.tt as BIG_LOOP has a length(size) of 1

To test:

1) go to More>Cataloging
2) click +New record
3) Click Settings> Fast add framework
4) take a look on console
5) try selecting a different framework now, will have no effect
6) apply patch and redo steps 1 to 5
7) there should be no error in console and a change in settings works a expected
Comment 2 Owen Leonard 2023-07-12 11:18:02 UTC 
Created attachment 153349 [details] [review]
Bug 34251: When using the fast add framework in addbiblio.pl there is thrown a JS error in selectTab( "#tab0XX_panel" );

This is because no nav tabs are build in addbiblio.tt as BIG_LOOP has a
length(size) of 1

To test:

1) go to More>Cataloging
2) click +New record
3) Click Settings> Fast add framework
4) take a look on console
5) try selecting a different framework now, will have no effect
6) apply patch and redo steps 1 to 5
7) there should be no error in console and a change in settings works a
   expected

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Katrin Fischer 2023-07-16 11:45:08 UTC 
Created attachment 153516 [details] [review]
Bug 34251: When using the fast add framework in addbiblio.pl there is thrown a JS error in selectTab( "#tab0XX_panel" );

This is because no nav tabs are build in addbiblio.tt as BIG_LOOP has a
length(size) of 1

To test:

1) go to More>Cataloging
2) click +New record
3) Click Settings> Fast add framework
4) take a look on console
5) try selecting a different framework now, will have no effect
6) apply patch and redo steps 1 to 5
7) there should be no error in console and a change in settings works a
   expected

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-07-18 15:47:52 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Martin Renvoize (ashimema) 2023-07-19 08:30:46 UTC 
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 6 Matt Blenkinsop 2023-07-19 10:15:35 UTC 
Nice work everyone!

Pushed to oldstable for 22.11.x
Comment 7 Nick Clemens (kidclamp) 2023-07-21 15:53:24 UTC 
*** Bug 34329 has been marked as a duplicate of this bug. ***