Bug 35238

Summary: Incorrect label markup in patron card creator printer profile edit form
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Eugene Espinoza <eugenegf>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: david, testopia
Version: MainKeywords: Academy, accessibility
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 35238: Incorrect label markup in patron card creator printer profile edit form
Bug 35238: Incorrect label markup in patron card creator printer profile edit form
Bug 35238: Incorrect label markup in patron card creator printer profile edit form
Bug 35238: Incorrect label markup in patron card creator printer profile edit form

Description Owen Leonard 2023-11-02 18:00:13 UTC
Tools -> Patron card creator -> Edit printer profile:

[% IF ( label_template ) %]
     <label for="template_name">Template name:</label>
    [% label_template | html %]
[% ELSE %]
     <span class="label">Template name:</span> Profile unassigned
[% END %]

The label for "template_name" doesn't match any form field, so it should be a span with "label" class.
Comment 1 Eugene Espinoza 2023-12-05 12:51:45 UTC
Created attachment 159577 [details] [review]
Bug 35238: Incorrect label markup in patron card creator printer profile edit form

HTML element for Template name is changed from 'label for "template_name"' to 'span with "label" class'.

So from:
<label for="template_name">Template name:</label>
It should now be:
<span class="label">Template name:</span>
Comment 2 Eugene Espinoza 2023-12-05 12:56:35 UTC
Created attachment 159578 [details] [review]
Bug 35238: Incorrect label markup in patron card creator printer profile edit form

HTML element for Template name is changed from 'label for "template_name"' to 'span with "label" class'.

So from:
<label for="template_name">Template name:</label>
It should now be:
<span class="label">Template name:</span>

To test:
1) Go to: Tools -> Patron card creator -> Edit printer profile.
2) Right click page and choose "View page source".
3) Locate the part with "Template name". It should read:
<span class="label">Template name:</span>
Comment 3 PTFS Europe Sandboxes 2024-04-19 03:34:03 UTC
Created attachment 165149 [details] [review]
Bug 35238: Incorrect label markup in patron card creator printer profile edit form

HTML element for Template name is changed from 'label for "template_name"' to 'span with "label" class'.

So from:
<label for="template_name">Template name:</label>
It should now be:
<span class="label">Template name:</span>

To test:
1) Go to: Tools -> Patron card creator -> Edit printer profile.
2) Right click page and choose "View page source".
3) Locate the part with "Template name". It should read:
<span class="label">Template name:</span>

Signed-off-by: Riomar Resurreccion <urslibrary.webinars@gmail.com>
Comment 4 PTFS Europe Sandboxes 2024-04-19 03:35:28 UTC
Created attachment 165150 [details] [review]
Bug 35238: Incorrect label markup in patron card creator printer profile edit form

HTML element for Template name is changed from 'label for "template_name"' to 'span with "label" class'.

So from:
<label for="template_name">Template name:</label>
It should now be:
<span class="label">Template name:</span>

To test:
1) Go to: Tools -> Patron card creator -> Edit printer profile.
2) Right click page and choose "View page source".
3) Locate the part with "Template name". It should read:
<span class="label">Template name:</span>

Signed-off-by: Riomar Resurreccion <urslibrary.webinars@gmail.com>
Comment 5 David Nind 2024-05-20 21:31:07 UTC
Added assignee.

Looks like it has been signed off as well.
Comment 6 David Nind 2024-05-20 21:31:47 UTC
Updated status to signed off.
Comment 7 David Nind 2024-05-20 21:36:54 UTC
Can confirm that the patch still applies, and things works as per the test plan.