Tools -> Patron card creator -> Edit printer profile: [% IF ( label_template ) %] <label for="template_name">Template name:</label> [% label_template | html %] [% ELSE %] <span class="label">Template name:</span> Profile unassigned [% END %] The label for "template_name" doesn't match any form field, so it should be a span with "label" class.
Created attachment 159577 [details] [review] Bug 35238: Incorrect label markup in patron card creator printer profile edit form HTML element for Template name is changed from 'label for "template_name"' to 'span with "label" class'. So from: <label for="template_name">Template name:</label> It should now be: <span class="label">Template name:</span>
Created attachment 159578 [details] [review] Bug 35238: Incorrect label markup in patron card creator printer profile edit form HTML element for Template name is changed from 'label for "template_name"' to 'span with "label" class'. So from: <label for="template_name">Template name:</label> It should now be: <span class="label">Template name:</span> To test: 1) Go to: Tools -> Patron card creator -> Edit printer profile. 2) Right click page and choose "View page source". 3) Locate the part with "Template name". It should read: <span class="label">Template name:</span>
Created attachment 165149 [details] [review] Bug 35238: Incorrect label markup in patron card creator printer profile edit form HTML element for Template name is changed from 'label for "template_name"' to 'span with "label" class'. So from: <label for="template_name">Template name:</label> It should now be: <span class="label">Template name:</span> To test: 1) Go to: Tools -> Patron card creator -> Edit printer profile. 2) Right click page and choose "View page source". 3) Locate the part with "Template name". It should read: <span class="label">Template name:</span> Signed-off-by: Riomar Resurreccion <urslibrary.webinars@gmail.com>
Created attachment 165150 [details] [review] Bug 35238: Incorrect label markup in patron card creator printer profile edit form HTML element for Template name is changed from 'label for "template_name"' to 'span with "label" class'. So from: <label for="template_name">Template name:</label> It should now be: <span class="label">Template name:</span> To test: 1) Go to: Tools -> Patron card creator -> Edit printer profile. 2) Right click page and choose "View page source". 3) Locate the part with "Template name". It should read: <span class="label">Template name:</span> Signed-off-by: Riomar Resurreccion <urslibrary.webinars@gmail.com>
Added assignee. Looks like it has been signed off as well.
Updated status to signed off.
Can confirm that the patch still applies, and things works as per the test plan.
Created attachment 168098 [details] [review] Bug 35238: Incorrect label markup in patron card creator printer profile edit form HTML element for Template name is changed from 'label for "template_name"' to 'span with "label" class'. So from: <label for="template_name">Template name:</label> It should now be: <span class="label">Template name:</span> To test: 1) Go to: Tools -> Patron card creator -> Edit printer profile. 2) Right click page and choose "View page source". 3) Locate the part with "Template name". It should read: <span class="label">Template name:</span> Signed-off-by: Riomar Resurreccion <urslibrary.webinars@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for 24.05.06