Bug 35262

Summary: Improve OPAC self registration confirmation page
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: david, fridolin.somers
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06,22.11.12
Circulation function:
Attachments: Slef registration confirmation page
Bug 35262: Improve OPAC self registration confirmation page
Bug 35262: Improve OPAC self registration confirmation page
Bug 35262: Improve OPAC self registration confirmation page

Description Katrin Fischer 2023-11-05 11:00:27 UTC
The OPAC self registration confirmation page has its content displayed without any margin to the left, directly at the outer line of the content box. This doesn't look very nice and could be improved.
Comment 1 Owen Leonard 2023-11-06 18:37:59 UTC
I don't think I can reproduce this problem. Can you attach a screenshot?
Comment 2 Katrin Fischer 2023-11-06 18:52:24 UTC
Created attachment 158542 [details]
Slef registration confirmation page

Tested without email verification.
Comment 3 David Nind 2023-11-06 19:01:12 UTC
Can confirm that I get the same results using Firefox (Developer Edition) and Chromium on Ubuntu 22.04.
Comment 4 Owen Leonard 2023-11-06 19:52:32 UTC Comment hidden (obsolete)
Comment 5 David Nind 2023-11-06 20:04:02 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2023-11-06 20:10:54 UTC
Created attachment 158560 [details] [review]
Bug 35262: Improve OPAC self registration confirmation page

This patch corrects logic in the OPAC self registration confirmation
template so that the right column markup is shown when various
combinations of OpacNav, OpacNavBottom, and OpacNavRight are displayed.

To test, apply the patch and enable the PatronSelfRegistration system
preference, and deactivate the PatronSelfRegistrationVerifyByEmail
preference.

- Go to the OPAC and start the process of registering online.
- Fill in the form and submit it.
- On the registration confirmation page, check that the layout looks
  correct.
- Test with the presence of various combinations of OpacNav,
  OpacNavBottom, and OpacNavRight HTML customizations.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi (tcohen) 2023-11-08 20:55:37 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-11-11 07:02:01 UTC
Small enhancement, I choose to backport

Pushed to 23.05.x for 23.05.06
Comment 9 Pedro Amorim 2023-11-14 15:02:53 UTC
Nice work everyone!

Pushed to 22.11.x for next release