Summary: | Remove drag and drop in Elasticsearch mappings | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Searching - Elasticsearch | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | barbara.petritsch, david, lucas, nick, tomascohen, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18827 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This removes the ability to drag and drop the order of the bibliographic and authorities search fields (Administration > Catalog > Search engine configuration (Elasticsearch)). This was removed as the feature has no effect on the search results when using Elasticsearch or OpenSearch as the search engine.
|
|
Version(s) released in: |
24.05.00,23.11.02
|
Circulation function: | |
Attachments: |
Bug 35265: Remove drag and drop in Elasticsearch mappings
Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 35265: Remove drag and drop in Elasticsearch mappings |
Description
Fridolin Somers
2023-11-06 06:41:59 UTC
Created attachment 158493 [details] [review] Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 18827 says ordering search fields in Elasticsearch mappings is useless. This patch removes it. Test plan : 1) Enable Elasticsearch 2) Go to Administration > Search engine configuration (Elasticsearch) 3) Go to tab 'Bibliographic records' 4) Check there is no Javscript error 5) Check you can't drag and drop lines anymore After that we may remove lib/jquery/plugins/jquery.tablednd.js looks like it is only used there. I'm working on Bug 35249 which removes the tablednd plugin in favor of the DataTables "official" extension. It is still needed for "Facet order" table found at the bottom of the Bibliographic records tab. Unless I'm wrong in thinking that table uses the row-reordering functionality? Created attachment 158582 [details] [review] Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 18827 says ordering search fields in Elasticsearch mappings is useless. This patch removes it. Test plan : 1) Enable Elasticsearch 2) Go to Administration > Search engine configuration (Elasticsearch) 3) Go to tab 'Bibliographic records' 4) Check there is no Javscript error 5) Check you can't drag and drop lines anymore Signed-off-by: David Nind <david@davidnind.com> Should there be any cleanup serverside for this? The patch removes the ability to drag and drop sort in the UI, but I'm struggling to see where/how that was stored serverside.. we should clean that side up too if it's really not useful. Can someone please verify whether table row reordering is still needed for the "Facet order" table? If so the plugin should not be removed. OK.. looking through the code I'm fairly certain now that the sort ordering was never really stored anywhere.. we just displayed in name alpha order always. I grabbed Nick.. he thinks the Facet Order does still matter. So we can move this bug forward as is.. but we'll want to tackle any change to the facet side in another bug. (In reply to Martin Renvoize from comment #8) > I grabbed Nick.. he thinks the Facet Order does still matter. > > So we can move this bug forward as is.. but we'll want to tackle any change > to the facet side in another bug. In other words.. bug 35249 is still valid I'm afraid Owen :) Created attachment 159083 [details] [review] Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 18827 says ordering search fields in Elasticsearch mappings is useless. This patch removes it. Test plan : 1) Enable Elasticsearch 2) Go to Administration > Search engine configuration (Elasticsearch) 3) Go to tab 'Bibliographic records' 4) Check there is no Javscript error 5) Check you can't drag and drop lines anymore Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> (In reply to Martin Renvoize from comment #9) > In other words.. bug 35249 is still valid I'm afraid Owen :) That's fine... I was trying to wait for Bug 34913 String changes, deferring (In reply to Martin Renvoize from comment #8) > I grabbed Nick.. he thinks the Facet Order does still matter. > > So we can move this bug forward as is.. but we'll want to tackle any change > to the facet side in another bug. Just double-checking: before this patch, we can re-order the facets and the changed order also was stored for me. This patch breaks this behaviour. Please confirm if this is indeed intended. You're right.. I must have switched branches mid-QA session as I know I tested it.. but it's really clearly removed here. Back to you Fridolin I'm afraid. Created attachment 159781 [details] [review] Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 18827 says ordering search fields in Elasticsearch mappings is useless. This patch removes it. Drag and drop is kept for facets. Test plan : 1) Enable Elasticsearch 2) Go to Administration > Search engine configuration (Elasticsearch) 3) Go to tab 'Bibliographic records' 4) Check there is no Javscript error 5) Check you can't drag and drop lines anymore Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> (In reply to Martin Renvoize from comment #14) > You're right.. I must have switched branches mid-QA session as I know I > tested it.. but it's really clearly removed here. > > Back to you Fridolin I'm afraid. Indeed :) I've restored DND for facets. Please re-test. Created attachment 159835 [details] [review] Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 18827 says ordering search fields in Elasticsearch mappings is useless. This patch removes it. Drag and drop is kept for facets. Test plan : 1) Enable Elasticsearch 2) Go to Administration > Search engine configuration (Elasticsearch) 3) Go to tab 'Bibliographic records' 4) Check there is no Javscript error 5) Check you can't drag and drop lines anymore Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Barbara Petritsch <barbara.petritsch@wienmuseum.at> Created attachment 160605 [details] [review] Bug 35265: Remove drag and drop in Elasticsearch mappings Bug 18827 says ordering search fields in Elasticsearch mappings is useless. This patch removes it. Drag and drop is kept for facets. Test plan : 1) Enable Elasticsearch 2) Go to Administration > Search engine configuration (Elasticsearch) 3) Go to tab 'Bibliographic records' 4) Check there is no Javscript error 5) Check you can't drag and drop lines anymore Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Barbara Petritsch <barbara.petritsch@wienmuseum.at> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works (facets still ok, adding, removing, editing biblio and auth record mappings too), makes sense, QA script happy, code looks good, passing QA :) Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.02 |