Bug 35295

Summary:	No hold modal when checking in an item of a held record
Product:	Koha	Reporter:	Victor Grousset/tuxayo <victor>
Component:	Circulation	Assignee:	Lucas Gass (lukeg) <lucas>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	blocker
Priority:	P5 - low	CC:	fridolin.somers, gmcharlt, kyle.m.hall, lucas, tomascohen
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00,23.05.06,22.11.12
Circulation function:
Bug Depends on:	31041
Bug Blocks:
Attachments:	Bug 35295: Move JS asset in returns.tt Bug 35295: Move JS asset in returns.tt Bug 35295: Move JS asset in returns.tt

Description Victor Grousset/tuxayo 2023-11-08 20:59:30 UTC

Test plan:
1. Place a hold
2. Check-in an item of the held record
3. No hold modal ﷐[U+1F631]﷑

After bisecting, the source is: bug 31041: (follow-up) Clean up and generalise

Comment 1 Lucas Gass (lukeg) 2023-11-08 21:20:10 UTC

Created attachment 158675 [details] [review]
Bug 35295: Move JS asset in returns.tt

To Test:
1. Place a hold
2. Check-in an item of the held record
3. No hold modal ﷐[U+1F631]﷑
4. APPLY PATCH
5. Hold modal!!!

Comment 2 David Nind 2023-11-08 21:59:52 UTC

Created attachment 158677 [details] [review]
Bug 35295: Move JS asset in returns.tt

To Test:
1. Place a hold
2. Check-in an item of the held record
3. No hold modal ﷐[U+1F631]﷑
4. APPLY PATCH
5. Hold modal!!!

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Tomás Cohen Arazi (tcohen) 2023-11-09 00:18:28 UTC

Thanks for promptly addressing it!

Looking forward to have this ready for pushing (my) early morning

Comment 4 Tomás Cohen Arazi (tcohen) 2023-11-09 13:18:06 UTC

Created attachment 158713 [details] [review]
Bug 35295: Move JS asset in returns.tt

To Test:
1. Place a hold
2. Check-in an item of the held record
3. No hold modal ﷐[U+1F631]﷑
4. APPLY PATCH
5. Hold modal!!!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Comment 5 Tomás Cohen Arazi (tcohen) 2023-11-09 13:18:49 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 6 Fridolin Somers 2023-11-11 07:15:39 UTC

Pushed to 23.05.x for 23.05.06

Comment 7 Pedro Amorim 2023-11-14 15:03:04 UTC

Nice work everyone!

Pushed to 22.11.x for next release