Bug 35295 - No hold modal when checking in an item of a held record
Summary: No hold modal when checking in an item of a held record
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low blocker (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on: 31041
Blocks:
  Show dependency treegraph
 
Reported: 2023-11-08 20:59 UTC by Victor Grousset/tuxayo
Modified: 2023-11-14 15:03 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06,22.11.12


Attachments
Bug 35295: Move JS asset in returns.tt (1.29 KB, patch)
2023-11-08 21:20 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35295: Move JS asset in returns.tt (1.33 KB, patch)
2023-11-08 21:59 UTC, David Nind
Details | Diff | Splinter Review
Bug 35295: Move JS asset in returns.tt (1.39 KB, patch)
2023-11-09 13:18 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Grousset/tuxayo 2023-11-08 20:59:30 UTC
Test plan:
1. Place a hold
2. Check-in an item of the held record
3. No hold modal 😱

After bisecting, the source is: bug 31041: (follow-up) Clean up and generalise
Comment 1 Lucas Gass 2023-11-08 21:20:10 UTC
Created attachment 158675 [details] [review]
Bug 35295: Move JS asset in returns.tt

To Test:
1. Place a hold
2. Check-in an item of the held record
3. No hold modal 😱
4. APPLY PATCH
5. Hold modal!!!
Comment 2 David Nind 2023-11-08 21:59:52 UTC
Created attachment 158677 [details] [review]
Bug 35295: Move JS asset in returns.tt

To Test:
1. Place a hold
2. Check-in an item of the held record
3. No hold modal 😱
4. APPLY PATCH
5. Hold modal!!!

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Tomás Cohen Arazi 2023-11-09 00:18:28 UTC
Thanks for promptly addressing it!

Looking forward to have this ready for pushing (my) early morning
Comment 4 Tomás Cohen Arazi 2023-11-09 13:18:06 UTC
Created attachment 158713 [details] [review]
Bug 35295: Move JS asset in returns.tt

To Test:
1. Place a hold
2. Check-in an item of the held record
3. No hold modal 😱
4. APPLY PATCH
5. Hold modal!!!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Tomás Cohen Arazi 2023-11-09 13:18:49 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-11-11 07:15:39 UTC
Pushed to 23.05.x for 23.05.06
Comment 7 Pedro Amorim 2023-11-14 15:03:04 UTC
Nice work everyone!

Pushed to 22.11.x for next release