Summary: | Fix capitalization of language name | ||
---|---|---|---|
Product: | Koha | Reporter: | Lari Taskula <lari.taskula> |
Component: | Templates | Assignee: | Lari Taskula <lari.taskula> |
Status: | Pushed to oldoldstable --- | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, fridolin.somers, lucas, phil, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the capitalization of English (english -> English) in the ILS_DI GetAvailability information page (<domainname>:<port>/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetAvailability).
|
Version(s) released in: |
24.05.00,23.11.01,23.05.07
|
Circulation function: | |||
Attachments: |
Bug 35327: Fix capitalization of language name
Bug 35327: Fix capitalization of language name Bug 35327: Fix capitalization of language name |
Description
Lari Taskula
2023-11-13 23:21:09 UTC
Created attachment 158901 [details] [review] Bug 35327: Fix capitalization of language name Also to clarify, it is not a keyword/parameter for English language, see https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132861 test plan step 5. The actual parameter would be a language code like "en" or "fr-FR". Perhaps documenting this in ilsdi.tt would be useful, but is outside the scope of this bug. Created attachment 158958 [details] [review] Bug 35327: Fix capitalization of language name Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. Enable the ILS-DI system preference. 2. Visit http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetAvailability 3. Search the page for english, and notice that english is not capitalised 4. Apply the patch, restart_all 5. Refresh the page 6. Note that English is now capitalised OR review the diff for the patch... Created attachment 159002 [details] [review] Bug 35327: Fix capitalization of language name Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Thanks David for the test plan :) Works, makes sense, QA script happy, code looks good, passing QA :) Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.01 Backported to 23.05.x for upcoming 23.05.07 |