Bug 35327 - Fix capitalization of language name
Summary: Fix capitalization of language name
Status: Pushed to oldoldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Lari Taskula
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-13 23:21 UTC by Lari Taskula
Modified: 2024-11-14 23:48 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the capitalization of English (english -> English) in the ILS_DI GetAvailability information page (<domainname>:<port>/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetAvailability).
Version(s) released in:
24.05.00,23.11.01,23.05.07
Circulation function:

Attachments
Bug 35327: Fix capitalization of language name (1.33 KB, patch)
2023-11-13 23:22 UTC, Lari Taskula 		Details | Diff | Splinter Review
Bug 35327: Fix capitalization of language name (1.37 KB, patch)
2023-11-14 23:24 UTC, David Nind 		Details | Diff | Splinter Review
Bug 35327: Fix capitalization of language name (1.43 KB, patch)
2023-11-15 17:50 UTC, Victor Grousset/tuxayo 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lari Taskula 2023-11-13 23:21:09 UTC 
Just a minor mistake I noticed while translating

koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt:176
english -> English
Comment 1 Lari Taskula 2023-11-13 23:22:18 UTC 
Created attachment 158901 [details] [review]
Bug 35327: Fix capitalization of language name
Comment 2 Lari Taskula 2023-11-14 13:11:20 UTC 
Also to clarify, it is not a keyword/parameter for English language, see https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132861 test plan step 5.

The actual parameter would be a language code like "en" or "fr-FR". Perhaps documenting this in ilsdi.tt would be useful, but is outside the scope of this bug.
Comment 3 David Nind 2023-11-14 23:24:41 UTC 
Created attachment 158958 [details] [review]
Bug 35327: Fix capitalization of language name

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-11-14 23:28:05 UTC 
Testing notes (using KTD):

1. Enable the ILS-DI system preference.
2. Visit http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetAvailability
3. Search the page for english, and notice that english is not capitalised
4. Apply the patch, restart_all
5. Refresh the page
6. Note that English is now capitalised

OR review the diff for the patch...
Comment 5 Victor Grousset/tuxayo 2023-11-15 17:50:47 UTC 
Created attachment 159002 [details] [review]
Bug 35327: Fix capitalization of language name

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 6 Victor Grousset/tuxayo 2023-11-15 17:52:33 UTC 
Thanks David for the test plan :)

Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 7 Katrin Fischer 2023-12-07 11:05:21 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 8 Fridolin Somers 2023-12-07 21:16:17 UTC 
Pushed to 23.11.x for 23.11.01
Comment 9 Lucas Gass (lukeg) 2023-12-14 20:42:57 UTC 
Backported to 23.05.x for upcoming 23.05.07