Bug 35347

Summary: 'More information' should always display in cookie consent bar
Product: Koha Reporter: Martin Renvoize (ashimema) <martin.renvoize>
Component: OPACAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: RESOLVED FIXED QA Contact: Victor Grousset/tuxayo <victor>
Severity: enhancement    
Priority: P5 - low CC: aude.charillon, fridolin.somers, victor
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:
Bug Depends on: 34793    
Bug Blocks: 34792, 35346    
Attachments: Bug 35347: Display 'More information' button regardless of JSConsents
Bug 35347: Display 'More information' button regardless of JSConsents
Bug 35347: (QA follow-up): swap "essential" and "all" for OPAC too
Bug 35347: Display 'More information' button regardless of JSConsents
Bug 35347: (QA follow-up): swap "essential" and "all" for OPAC too

Description Martin Renvoize (ashimema) 2023-11-16 11:19:05 UTC
Even if we only have essential cookies use on the system, if the CookieConsent option is set to required the footer conent bar should display the 'More information' button so a user can make an informed decision whether to continue using the site or not.
Comment 1 Martin Renvoize (ashimema) 2023-11-16 13:17:15 UTC
Created attachment 159045 [details] [review]
Bug 35347: Display 'More information' button regardless of JSConsents

This patch moves the "More informatin" button outside of the JSConsents
block so that you are able to access the information modal regardless of
whether you have tracking cookies added to your configuration or not.

Test plan
1) Enable CookieConsent
2) Note that the 'More information' button now appears in the footer on
   both staff and opac until you have accepted cookies.
Comment 2 David Nind 2023-11-20 09:51:20 UTC
Created attachment 159136 [details] [review]
Bug 35347: Display 'More information' button regardless of JSConsents

This patch moves the "More informatin" button outside of the JSConsents
block so that you are able to access the information modal regardless of
whether you have tracking cookies added to your configuration or not.

Test plan
1) Enable CookieConsent
2) Note that the 'More information' button now appears in the footer on
   both staff and opac until you have accepted cookies.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Victor Grousset/tuxayo 2024-02-11 07:06:30 UTC
Created attachment 162013 [details] [review]
Bug 35347: (QA follow-up): swap "essential" and "all" for OPAC too
Comment 4 Victor Grousset/tuxayo 2024-02-11 18:01:35 UTC
All good for me. Waiting for bug 34793.
Comment 5 Victor Grousset/tuxayo 2024-02-12 15:51:48 UTC
Created attachment 162057 [details] [review]
Bug 35347: Display 'More information' button regardless of JSConsents

This patch moves the "More informatin" button outside of the JSConsents
block so that you are able to access the information modal regardless of
whether you have tracking cookies added to your configuration or not.

Test plan
1) Enable CookieConsent
2) Note that the 'More information' button now appears in the footer on
   both staff and opac until you have accepted cookies.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 6 Victor Grousset/tuxayo 2024-02-12 15:51:50 UTC
Created attachment 162058 [details] [review]
Bug 35347: (QA follow-up): swap "essential" and "all" for OPAC too
Comment 7 Victor Grousset/tuxayo 2024-02-12 15:52:21 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 8 Katrin Fischer 2024-03-26 10:09:42 UTC
Note:
<button type="button" class="btn btn-info" id="consentMoreInfo" aria-label="Click to view more information about your cookie consents">

The "click to view" is not needed here as it's marked as a button. Accessibility guidelines recommend to not use click and similar on links and such. Unrelated to the patch (pre-existing), but maybe someone wants to pick it up as an academy bug.
Comment 9 Katrin Fischer 2024-03-26 10:21:56 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 10 Fridolin Somers 2024-05-22 12:32:23 UTC
Depends on Bug 34793 not in 23.11.x