Bug 34793 - We should ship default 'CookieConsentPopup' data that describes our required cookies
Summary: We should ship default 'CookieConsentPopup' data that describes our required ...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aude Charillon
QA Contact: Testopia
URL:
Keywords:
Depends on: 27378
Blocks: 35347
  Show dependency treegraph
 
Reported: 2023-09-14 15:14 UTC by Martin Renvoize
Modified: 2023-11-21 17:48 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 34793: Add default HTML Customisations for cookie information (6.27 KB, patch)
2023-11-17 15:37 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy' (2.08 KB, patch)
2023-11-17 15:37 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 34793: Add default HTML Customisations for cookie information (6.27 KB, patch)
2023-11-17 15:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy' (2.08 KB, patch)
2023-11-17 15:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 34793: (follow-up) Add table classes to popup (1.31 KB, patch)
2023-11-20 08:01 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 34793: Add default HTML Customisations for cookie information (6.31 KB, patch)
2023-11-20 09:47 UTC, David Nind
Details | Diff | Splinter Review
Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy' (2.13 KB, patch)
2023-11-20 09:47 UTC, David Nind
Details | Diff | Splinter Review
Bug 34793: (follow-up) Add table classes to popup (1.36 KB, patch)
2023-11-20 09:47 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-09-14 15:14:01 UTC
Without any further configuration of the CookieConsent feature, after enabling it the 'More information' button is missing from the consent bar but clicking 'accept' exposes a 'Your cookies' link if you're not logged in (or a 'View cookie consents' if you are logged in and looking at your 'Consents' tab in your account).

These all trigger the cookie consents modal with no content in.. I really think we should include some default sample data in there explaining our required cookies.. and I think we should always show the 'More information' button from the Consent bar..
Comment 1 Katrin Fischer 2023-09-19 21:14:32 UTC
The issue I see here is that our required cookies don't require consent - they cannot be avoided if you want to use the OPAC.
I am not sure how that would fit the modal.
Comment 2 Martin Renvoize 2023-09-20 15:52:45 UTC
Just because they're required for operation doesn't mean we should hide them.  We should have encouraged best practice which is to inform the user what the required cookies are used for.. That way then can then choose to opt out of using your service if they believe the required cookies are over the top.
Comment 3 Aude Charillon 2023-09-28 13:57:40 UTC
I'm all for informing users! Even if all the cookies are required and there is no choice for the user, we have to tell them what's happening.

Can we slightly shift the cookie consent feature so that it's not just about the consent but mostly about the cookies?
Or do we need a default Opac page about required cookies, with a link from the Opac footer?
(Just throwing ideas wildly here.)
Comment 4 Martin Renvoize 2023-11-17 15:37:24 UTC
Created attachment 159089 [details] [review]
Bug 34793: Add default HTML Customisations for cookie information

This patch adds some default html customisation content for the cookie
consent feature.

Test plan
1) Run through the installer and pick to import the sample news items
2) Confirm that after enabling the CookieConsent preference that the
   default content appears in the cookie bar at the bottom of the page
   and in the modal that appears after clicking 'More information'

Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2023-11-17 15:37:27 UTC
Created attachment 159090 [details] [review]
Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy'

The modal is not always about consent, but rather about displaying the
libraries cookie policy. It makes sense to update the heading to reflect
that.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2023-11-17 15:38:24 UTC
Aude did all the hard work here putting together the text, I just helped to construct the patch and upload it.

Great work Aude, I think it looks much better now as a feature.
Comment 7 Martin Renvoize 2023-11-17 15:42:39 UTC
Created attachment 159094 [details] [review]
Bug 34793: Add default HTML Customisations for cookie information

This patch adds some default html customisation content for the cookie
consent feature.

Test plan
1) Run through the installer and pick to import the sample news items
2) Confirm that after enabling the CookieConsent preference that the
   default content appears in the cookie bar at the bottom of the page
   and in the modal that appears after clicking 'More information'

Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize 2023-11-17 15:42:42 UTC
Created attachment 159095 [details] [review]
Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy'

The modal is not always about consent, but rather about displaying the
libraries cookie policy. It makes sense to update the heading to reflect
that.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Martin Renvoize 2023-11-17 15:42:59 UTC
Quick typo fix applied ;P
Comment 10 David Nind 2023-11-18 23:07:57 UTC
I've tested and am happy to sign off.

Comments/suggestions:

1. Should the cookie bar link to the cookie policy? I only see this in the OPAC by going to Your account > Consents > under Cookies policy is "View your cookie consents" button > pop up window has "Accept all cookies" irrespective of whether you have clicked on the "Accept all cookies" in the cookie bar.

2. The table in the Consent policy page in the OPAC. It looks fine when you preview in Tools. However, in the OPAC it has hard to read as the rows are aligned to the center, with no alternate row colours or border between rows. Can the table rows be aligned to the top, and formatted similar to the staff interface tools preview?

3. I'm not sure that I understand the normal workflow for this from a patron perspective, even after reading through bug 27378, and how it works with the privacy policy.
 

Testing notes:

1. Starting the web installer in KTD: https://gitlab.com/-/snippets/1893788#user-content-starting-the-web-installer
Comment 11 Martin Renvoize 2023-11-20 07:58:29 UTC
(In reply to David Nind from comment #10)
> I've tested and am happy to sign off.
> 
> Comments/suggestions:
> 
> 1. Should the cookie bar link to the cookie policy? I only see this in the
> OPAC by going to Your account > Consents > under Cookies policy is "View
> your cookie consents" button > pop up window has "Accept all cookies"
> irrespective of whether you have clicked on the "Accept all cookies" in the
> cookie bar.

Right now it depends.. but follow the tree here and you'll find we fixed that too in one of the next bugs ;P

> 2. The table in the Consent policy page in the OPAC. It looks fine when you
> preview in Tools. However, in the OPAC it has hard to read as the rows are
> aligned to the center, with no alternate row colours or border between rows.
> Can the table rows be aligned to the top, and formatted similar to the staff
> interface tools preview?

Looks like we missed the classes (annoyingly, the preview in staff always uses the staff css.. we should fix that somehow really)

> 3. I'm not sure that I understand the normal workflow for this from a patron
> perspective, even after reading through bug 27378, and how it works with the
> privacy policy.

It's in the documentation list.. hopefully aude and I can work through it asap.

> Testing notes:
> 
> 1. Starting the web installer in KTD:
> https://gitlab.com/-/snippets/1893788#user-content-starting-the-web-installer
Comment 12 Martin Renvoize 2023-11-20 08:01:29 UTC
Created attachment 159132 [details] [review]
Bug 34793: (follow-up) Add table classes to popup

This patch adds the appropriate table classes to the Popup html
customisation block. This ensure we have proper table display formatting
in the modal on the OPAC.
Comment 13 Martin Renvoize 2023-11-20 08:05:07 UTC
PS, I set up a sandboxes with the full set of bugs applied if, it includes the follow-up I just added here too.

http://opac-cookies.sandboxes.ptfs-europe.co.uk
Comment 14 David Nind 2023-11-20 09:47:41 UTC
Created attachment 159133 [details] [review]
Bug 34793: Add default HTML Customisations for cookie information

This patch adds some default html customisation content for the cookie
consent feature.

Test plan
1) Run through the installer and pick to import the sample news items
2) Confirm that after enabling the CookieConsent preference that the
   default content appears in the cookie bar at the bottom of the page
   and in the modal that appears after clicking 'More information'

Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: David Nind <david@davidnind.com>
Comment 15 David Nind 2023-11-20 09:47:44 UTC
Created attachment 159134 [details] [review]
Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy'

The modal is not always about consent, but rather about displaying the
libraries cookie policy. It makes sense to update the heading to reflect
that.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: David Nind <david@davidnind.com>
Comment 16 David Nind 2023-11-20 09:47:47 UTC
Created attachment 159135 [details] [review]
Bug 34793: (follow-up) Add table classes to popup

This patch adds the appropriate table classes to the Popup html
customisation block. This ensure we have proper table display formatting
in the modal on the OPAC.

Signed-off-by: David Nind <david@davidnind.com>
Comment 17 David Nind 2023-11-20 09:49:03 UTC
(In reply to Martin Renvoize from comment #13)
> PS, I set up a sandboxes with the full set of bugs applied if, it includes
> the follow-up I just added here too.
> 
> http://opac-cookies.sandboxes.ptfs-europe.co.uk

Thanks Martin! I had missed the other bugs. I can see the bigger picture now...

Thanks also for fixing the CSS for the OPAC display.