Bug 35351

Summary: Adjust basket details template to avoid showing empty page-section
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Emily Lamancusa (emlam) <emily.lamancusa>
Severity: trivial    
Priority: P5 - low CC: david, emily.lamancusa, fridolin.somers, lucas
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
This removes the empty white section in acquisitions for a basket with no orders.
Version(s) released in:
24.05.00,23.11.04,23.05.10
Circulation function:
Attachments: Bug 35351: Adjust basket details template to avoid showing empty page-section
Bug 35351: Adjust basket details template to avoid showing empty page-section
Bug 35351: Adjust basket details template to avoid showing empty page-section

Description Owen Leonard 2023-11-16 14:10:27 UTC
We shouldn't show an empty page-section div when there are no orders to show.
Comment 1 Owen Leonard 2023-11-16 14:25:11 UTC
Created attachment 159052 [details] [review]
Bug 35351: Adjust basket details template to avoid showing empty page-section

This patch makes a minor change to the markup of the basket details page
so that we don't display an empty div.page-section when there are no
orders.

Note: This patch includes whitespace changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Acquisitions.

- Search for a vendor and add a basket if necessary.
- View the details of an empty basket.
- Under the "General information" or "Settings" sections there should be
  no empty white box.
- View the details of a basket which has orders (using the "Add to
  basket" process if necessary).
  - Orders should be displayed correctly.
Comment 2 David Nind 2023-12-11 20:22:15 UTC
Created attachment 159719 [details] [review]
Bug 35351: Adjust basket details template to avoid showing empty page-section

This patch makes a minor change to the markup of the basket details page
so that we don't display an empty div.page-section when there are no
orders.

Note: This patch includes whitespace changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Acquisitions.

- Search for a vendor and add a basket if necessary.
- View the details of an empty basket.
- Under the "General information" or "Settings" sections there should be
  no empty white box.
- View the details of a basket which has orders (using the "Add to
  basket" process if necessary).
  - Orders should be displayed correctly.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Emily Lamancusa (emlam) 2024-01-25 18:00:55 UTC
Created attachment 161455 [details] [review]
Bug 35351: Adjust basket details template to avoid showing empty page-section

This patch makes a minor change to the markup of the basket details page
so that we don't display an empty div.page-section when there are no
orders.

Note: This patch includes whitespace changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Acquisitions.

- Search for a vendor and add a basket if necessary.
- View the details of an empty basket.
- Under the "General information" or "Settings" sections there should be
  no empty white box.
- View the details of a basket which has orders (using the "Add to
  basket" process if necessary).
  - Orders should be displayed correctly.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Emily Lamancusa (emlam) 2024-01-25 18:07:02 UTC
Looks good, QA script is happy. Passing QA
Comment 5 Katrin Fischer 2024-03-07 14:03:50 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-03-11 09:36:27 UTC
Pushed to 23.11.x for 23.11.04
Comment 7 Lucas Gass (lukeg) 2024-03-19 15:19:42 UTC
Backported to 23.05.x for upcoming 23.05.10