Summary: | Adjust basket details template to avoid showing empty page-section | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, emily.lamancusa, fridolin.somers, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This removes the empty white section in acquisitions for a basket with no orders.
|
|
Version(s) released in: |
24.05.00,23.11.04,23.05.10
|
Circulation function: | |
Attachments: |
Bug 35351: Adjust basket details template to avoid showing empty page-section
Bug 35351: Adjust basket details template to avoid showing empty page-section Bug 35351: Adjust basket details template to avoid showing empty page-section |
Description
Owen Leonard
2023-11-16 14:10:27 UTC
Created attachment 159052 [details] [review] Bug 35351: Adjust basket details template to avoid showing empty page-section This patch makes a minor change to the markup of the basket details page so that we don't display an empty div.page-section when there are no orders. Note: This patch includes whitespace changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Acquisitions. - Search for a vendor and add a basket if necessary. - View the details of an empty basket. - Under the "General information" or "Settings" sections there should be no empty white box. - View the details of a basket which has orders (using the "Add to basket" process if necessary). - Orders should be displayed correctly. Created attachment 159719 [details] [review] Bug 35351: Adjust basket details template to avoid showing empty page-section This patch makes a minor change to the markup of the basket details page so that we don't display an empty div.page-section when there are no orders. Note: This patch includes whitespace changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Acquisitions. - Search for a vendor and add a basket if necessary. - View the details of an empty basket. - Under the "General information" or "Settings" sections there should be no empty white box. - View the details of a basket which has orders (using the "Add to basket" process if necessary). - Orders should be displayed correctly. Signed-off-by: David Nind <david@davidnind.com> Created attachment 161455 [details] [review] Bug 35351: Adjust basket details template to avoid showing empty page-section This patch makes a minor change to the markup of the basket details page so that we don't display an empty div.page-section when there are no orders. Note: This patch includes whitespace changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Acquisitions. - Search for a vendor and add a basket if necessary. - View the details of an empty basket. - Under the "General information" or "Settings" sections there should be no empty white box. - View the details of a basket which has orders (using the "Add to basket" process if necessary). - Orders should be displayed correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Looks good, QA script is happy. Passing QA Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.04 Backported to 23.05.x for upcoming 23.05.10 |