Summary: | Remove comment about bug 8000 in gather_print_notices.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | Command-line Utilities | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, lucas, robin, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.05.00,23.11.03,23.05.09
|
Circulation function: | |
Attachments: |
Bug 35373: Remove false FIXME comment from gather_print_notices.pl
Bug 35373: Remove false FIXME comment from gather_print_notices.pl Bug 35373: Remove false FIXME comment from gather_print_notices.pl |
Description
Magnus Enger
2023-11-21 07:32:18 UTC
Created attachment 161012 [details] [review] Bug 35373: Remove false FIXME comment from gather_print_notices.pl Removes a FIXME line mentioning bug 8000 that implemented SendAllEmailsTo. But the note was added to the "From" line and the "To" address is taken from a command line parameter. To test: * Review change carefully Created attachment 161361 [details] [review] Bug 35373: Remove false FIXME comment from gather_print_notices.pl Removes a FIXME line mentioning bug 8000 that implemented SendAllEmailsTo. But the note was added to the "From" line and the "To" address is taken from a command line parameter. To test: * Review change carefully Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 161426 [details] [review] Bug 35373: Remove false FIXME comment from gather_print_notices.pl Removes a FIXME line mentioning bug 8000 that implemented SendAllEmailsTo. But the note was added to the "From" line and the "To" address is taken from a command line parameter. To test: * Review change carefully Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I don't think the FIXME as it stands ever made sense.. Passing QA Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.03 Backported to 23.05.x for upcoming 23.05.09 Not backporting to 22.11 |