Description
Katrin Fischer
2023-11-21 10:41:04 UTC
Created attachment 159155 [details] [review] Bug 35374: Remove ES6 template literals to fix translation strings The .po files contains the whole block after this line. I don't really understand what's happening but this change fixes the problem. Test plan: 1. Run the following command before and after the patch and compare the diff % gulp po:update --lang de-DE --task messages-js 2. Confirm that the list on this vue is correctly populated Created attachment 159172 [details] [review] Bug 35374: Remove ES6 template literals to fix translation strings The .po files contains the whole block after this line. I don't really understand what's happening but this change fixes the problem. Test plan: 1. Run the following command before and after the patch and compare the diff % gulp po:update --lang de-DE --task messages-js 2. Confirm that the list on this vue is correctly populated Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Matt, you need to change the status as you have signed it off. I would do it, but then you wouldn't get the credit on the dashboard 8-) Good spot, forgot to do the attach -e! Created attachment 159194 [details] [review] Bug 35374: Remove ES6 template literals to fix translation strings The .po files contains the whole block after this line. I don't really understand what's happening but this change fixes the problem. Test plan: 1. Run the following command before and after the patch and compare the diff % gulp po:update --lang de-DE --task messages-js 2. Confirm that the list on this vue is correctly populated Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 159195 [details] [review] Bug 35374: Remove ES6 template literals to fix translation strings The .po files contains the whole block after this line. I don't really understand what's happening but this change fixes the problem. Test plan: 1. Run the following command before and after the patch and compare the diff % gulp po:update --lang de-DE --task messages-js 2. Confirm that the list on this vue is correctly populated Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 23.11. Nice work everyone, thanks! koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsProviderDataList.vue created by Bug 34587 |