https://translate.koha-community.org/translate/koha/master/messages-js/de/?checksum=a8b31c9919434571 This shouldn't appear in translations: return url }, getTableColumns() { const column_options = [ { used_by: ["title", "platform", "item", "database"], column: { title: __( this.data_type.charAt(0).toUpperCase() + this.data_type.slice(1) ), data: this.data_type, searchable: true, orderable: true, }, }, { used_by: ["item", "database", "platforms"], column: { title: "Platform", data: "platform", searchable: true, orderable: true, }, }, { used_by: ["title", "item", "database"], column: { title: "Publisher", data: "publisher", searchable: true, orderable: true, }, }, { used_by: ["title", "database"], column: { title: "Publisher ID", data: "publisher_id", searchable: true, orderable: true, }, }, { used_by: ["title"], column: { title: "DOI", data: "title_doi", searchable: true, orderable: true, }, }, { used_by: ["title"], column: { title: "Print ISSN", data: "print_issn", searchable: true, orderable: true, }, }, { used_by: ["title"], column: { title: "Online ISSN", data: "online_issn", searchable: true, orderable: true, }, }, { used_by: ["title"], column: { title: "URI", data: "title_uri", searchable: true, orderable: true, }, }, ] const columns = column_options .filter(column => column.used_by.includes(this.data_type)) .map(result => result.column) return columns }, }, mounted() { if (!this.building_table) { this.building_table = true this.getData() } }, props: ["data_type"], components: { KohaTable }, name: "UsageStatisticsProviderDataList", } </script> <style scoped> #title_list { display: table; } </style>
Created attachment 159155 [details] [review] Bug 35374: Remove ES6 template literals to fix translation strings The .po files contains the whole block after this line. I don't really understand what's happening but this change fixes the problem. Test plan: 1. Run the following command before and after the patch and compare the diff % gulp po:update --lang de-DE --task messages-js 2. Confirm that the list on this vue is correctly populated
Created attachment 159172 [details] [review] Bug 35374: Remove ES6 template literals to fix translation strings The .po files contains the whole block after this line. I don't really understand what's happening but this change fixes the problem. Test plan: 1. Run the following command before and after the patch and compare the diff % gulp po:update --lang de-DE --task messages-js 2. Confirm that the list on this vue is correctly populated Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Matt, you need to change the status as you have signed it off. I would do it, but then you wouldn't get the credit on the dashboard 8-)
Good spot, forgot to do the attach -e!
Created attachment 159194 [details] [review] Bug 35374: Remove ES6 template literals to fix translation strings The .po files contains the whole block after this line. I don't really understand what's happening but this change fixes the problem. Test plan: 1. Run the following command before and after the patch and compare the diff % gulp po:update --lang de-DE --task messages-js 2. Confirm that the list on this vue is correctly populated Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 159195 [details] [review] Bug 35374: Remove ES6 template literals to fix translation strings The .po files contains the whole block after this line. I don't really understand what's happening but this change fixes the problem. Test plan: 1. Run the following command before and after the patch and compare the diff % gulp po:update --lang de-DE --task messages-js 2. Confirm that the list on this vue is correctly populated Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 23.11. Nice work everyone, thanks!
koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsProviderDataList.vue created by Bug 34587
Bug 34587 not in 23.05.x