Bug 35376

Summary: Rephrase: Be careful removing attribute to this processing, the items using it will be impacted as well!
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: I18N/L10NAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Kyle M Hall (khall) <kyle>
Severity: minor    
Priority: P5 - low CC: f.demians, fridolin.somers, jonathan.druart, kyle, lucas
Version: MainKeywords: Academy
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.01
Circulation function:
Bug Depends on: 30708    
Bug Blocks:    
Attachments: Bug 35376: Rephrase "be careful..."
Bug 35376: Rephrase "be careful..."
Bug 35376: Rephrase "be careful..."

Description Katrin Fischer 2023-11-21 12:01:29 UTC
It feels like this might be missing a word:

Be careful removing attribute to this processing, the items using it will be impacted as well!

koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessingsFormAdd.vue:49
Comment 1 Jonathan Druart 2023-11-21 12:44:37 UTC
Is that better?
"Be careful when removing attributes from this processing: the items using it will be impacted as well!"
Comment 2 Katrin Fischer 2023-11-27 18:02:52 UTC
yes!
Comment 3 Jonathan Druart 2023-11-28 10:40:01 UTC
Created attachment 159285 [details] [review]
Bug 35376: Rephrase "be careful..."
Comment 4 David Nind 2023-11-29 10:26:45 UTC
Created attachment 159325 [details] [review]
Bug 35376: Rephrase "be careful..."

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Kyle M Hall (khall) 2023-12-01 17:28:19 UTC
Created attachment 159469 [details] [review]
Bug 35376: Rephrase "be careful..."

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Katrin Fischer 2023-12-07 11:05:24 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2023-12-07 21:19:52 UTC
Pushed to 23.11.x for 23.11.01
Comment 8 Lucas Gass (lukeg) 2023-12-14 20:51:27 UTC
Not needed int 23.05.x, no backport.