Bug 35378

Summary: 'This authority type is used {count} times' missing dot
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: TemplatesAssignee: Tomás Cohen Arazi <tomascohen>
Status: RESOLVED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: trivial    
Priority: P5 - low CC: david, fridolin.somers, lucas, m.de.rooy, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.01
Attachments: Bug 35378: 'This authority type is used {count} times' missing dot
Bug 35378: 'This authority type is used {count} times' missing dot
Bug 35378: 'This authority type is used {count} times' missing dot

Description Tomás Cohen Arazi 2023-11-21 17:29:33 UTC

    
Comment 1 Tomás Cohen Arazi 2023-11-21 17:31:23 UTC
Created attachment 159173 [details] [review]
Bug 35378: 'This authority type is used {count} times' missing dot
Comment 2 David Nind 2023-11-21 19:54:35 UTC
Created attachment 159179 [details] [review]
Bug 35378: 'This authority type is used {count} times' missing dot

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-11-21 19:57:58 UTC
Testing notes (using KTD):

1. Go to Administration > Catalog > Authority types.
2. For the PERSO_NAM (Personal name) authorty type actions, select 'Delete'.
3. Note that the message says "This authority type is used 650 times" (no full stop at the end of the sentence).
4. Apply the patch.
5. Refresh the page.
6. The message now says "This authority type is used 650 times." (now has a full stop at the end of the sentence).
Comment 4 Marcel de Rooy 2023-11-24 09:24:51 UTC
Created attachment 159232 [details] [review]
Bug 35378: 'This authority type is used {count} times' missing dot

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Marcel de Rooy 2023-11-24 09:25:29 UTC
RM: You know that this contains a string change :)
Comment 6 Katrin Fischer 2023-12-07 11:05:27 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Tomás Cohen Arazi 2023-12-07 13:08:01 UTC
(In reply to Marcel de Rooy from comment #5)
> RM: You know that this contains a string change :)

XD
Comment 8 Fridolin Somers 2023-12-07 21:17:27 UTC
Pushed to 23.11.x for 23.11.01
Comment 9 Lucas Gass 2023-12-14 20:47:15 UTC
This doesn't appear to be needed in 23.05.x, no backport.