35378 – 'This authority type is used {count} times' missing dot

Bug 35378 - 'This authority type is used {count} times' missing dot

Summary: 'This authority type is used {count} times' missing dot

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Templates (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P5 - low trivial
Assignee:	Tomás Cohen Arazi (tcohen)
QA Contact:	Marcel de Rooy

URL:
Keywords:

Depends on:
Blocks:

Reported:	2023-11-21 17:29 UTC by Tomás Cohen Arazi (tcohen)
Modified:	2024-12-23 08:06 UTC (History)
CC List:	5 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:	24.05.00,23.11.01
Circulation function:

Attachments
Bug 35378: 'This authority type is used {count} times' missing dot (1.42 KB, patch) 2023-11-21 17:31 UTC, Tomás Cohen Arazi (tcohen)	Details \| Diff \| Splinter Review
Bug 35378: 'This authority type is used {count} times' missing dot (1.46 KB, patch) 2023-11-21 19:54 UTC, David Nind	Details \| Diff \| Splinter Review
Bug 35378: 'This authority type is used {count} times' missing dot (1.56 KB, patch) 2023-11-24 09:24 UTC, Marcel de Rooy	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tomás Cohen Arazi (tcohen) 2023-11-21 17:29:33 UTC

Comment 1 Tomás Cohen Arazi (tcohen) 2023-11-21 17:31:23 UTC

Created attachment 159173 [details] [review]
Bug 35378: 'This authority type is used {count} times' missing dot

Comment 2 David Nind 2023-11-21 19:54:35 UTC

Created attachment 159179 [details] [review]
Bug 35378: 'This authority type is used {count} times' missing dot

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 David Nind 2023-11-21 19:57:58 UTC

Testing notes (using KTD):

1. Go to Administration > Catalog > Authority types.
2. For the PERSO_NAM (Personal name) authorty type actions, select 'Delete'.
3. Note that the message says "This authority type is used 650 times" (no full stop at the end of the sentence).
4. Apply the patch.
5. Refresh the page.
6. The message now says "This authority type is used 650 times." (now has a full stop at the end of the sentence).

Comment 4 Marcel de Rooy 2023-11-24 09:24:51 UTC

Created attachment 159232 [details] [review]
Bug 35378: 'This authority type is used {count} times' missing dot

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 5 Marcel de Rooy 2023-11-24 09:25:29 UTC

RM: You know that this contains a string change :)

Comment 6 Katrin Fischer 2023-12-07 11:05:27 UTC

Pushed for 24.05!

Well done everyone, thank you!

Comment 7 Tomás Cohen Arazi (tcohen) 2023-12-07 13:08:01 UTC

(In reply to Marcel de Rooy from comment #5)
> RM: You know that this contains a string change :)

XD

Comment 8 Fridolin Somers 2023-12-07 21:17:27 UTC

Pushed to 23.11.x for 23.11.01

Comment 9 Lucas Gass (lukeg) 2023-12-14 20:47:15 UTC

This doesn't appear to be needed in 23.05.x, no backport.