Bug 35379

Summary: 'searchfield' parameter name misleading when translating
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: TemplatesAssignee: Tomás Cohen Arazi (tcohen) <tomascohen>
Status: Pushed to oldstable --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: david, fridolin.somers, jonathan.druart, phil, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03
Circulation function:
Bug Depends on: 34412    
Bug Blocks:    
Attachments: Bug 35379: Rename tx() parameter to ease translation
Bug 35379: Rename tx() parameter to ease translation
Bug 35379: Rename tx() parameter to ease translation

Description Tomás Cohen Arazi (tcohen) 2023-11-21 18:06:52 UTC
In this file:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt

this would read better

tx("Modify system preference '{searchfield}'", { searchfield = searchfield })

if the parameter was renamed to system_preference like the in the rest of the file.
Comment 1 Tomás Cohen Arazi (tcohen) 2023-11-21 18:08:56 UTC
Created attachment 159176 [details] [review]
Bug 35379: Rename tx() parameter to ease translation
Comment 2 David Nind 2023-11-21 23:42:36 UTC
Created attachment 159187 [details] [review]
Bug 35379: Rename tx() parameter to ease translation

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-11-21 23:44:49 UTC
Testing notes (using KTD):

1. Able to add and edit 'Local use" system preferences after patch applied - no changes noticed.
Comment 4 Jonathan Druart 2024-01-12 10:45:18 UTC
Created attachment 160922 [details] [review]
Bug 35379: Rename tx() parameter to ease translation

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Katrin Fischer 2024-01-16 15:36:04 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-01-31 12:23:44 UTC
Pushed to 23.11.x for 23.11.03