| Summary: | 'searchfield' parameter name misleading when translating | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Templates | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, jonathan.druart, phil, tomascohen, wainuiwitikapark |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.03
|
|
| Circulation function: | |||
| Bug Depends on: | 34412 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 35379: Rename tx() parameter to ease translation
Bug 35379: Rename tx() parameter to ease translation Bug 35379: Rename tx() parameter to ease translation |
||
Created attachment 159176 [details] [review] Bug 35379: Rename tx() parameter to ease translation Created attachment 159187 [details] [review] Bug 35379: Rename tx() parameter to ease translation Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. Able to add and edit 'Local use" system preferences after patch applied - no changes noticed. Created attachment 160922 [details] [review] Bug 35379: Rename tx() parameter to ease translation Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.03 Not backporting to 22.11 unless requested |
In this file: koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt this would read better tx("Modify system preference '{searchfield}'", { searchfield = searchfield }) if the parameter was renamed to system_preference like the in the rest of the file.