Bug 35379 - 'searchfield' parameter name misleading when translating
Summary: 'searchfield' parameter name misleading when translating
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Testopia
URL:
Keywords:
Depends on: 34412
Blocks:
  Show dependency tree / graph
 
Reported: 2023-11-21 18:06 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2024-11-15 00:51 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03
Circulation function:

Attachments
Bug 35379: Rename tx() parameter to ease translation (1.08 KB, patch)
2023-11-21 18:08 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 35379: Rename tx() parameter to ease translation (1.12 KB, patch)
2023-11-21 23:42 UTC, David Nind 		Details | Diff | Splinter Review
Bug 35379: Rename tx() parameter to ease translation (1.20 KB, patch)
2024-01-12 10:45 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2023-11-21 18:06:52 UTC 
In this file:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt

this would read better

tx("Modify system preference '{searchfield}'", { searchfield = searchfield })

if the parameter was renamed to system_preference like the in the rest of the file.
Comment 1 Tomás Cohen Arazi (tcohen) 2023-11-21 18:08:56 UTC 
Created attachment 159176 [details] [review]
Bug 35379: Rename tx() parameter to ease translation
Comment 2 David Nind 2023-11-21 23:42:36 UTC 
Created attachment 159187 [details] [review]
Bug 35379: Rename tx() parameter to ease translation

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-11-21 23:44:49 UTC 
Testing notes (using KTD):

1. Able to add and edit 'Local use" system preferences after patch applied - no changes noticed.
Comment 4 Jonathan Druart 2024-01-12 10:45:18 UTC 
Created attachment 160922 [details] [review]
Bug 35379: Rename tx() parameter to ease translation

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Katrin Fischer 2024-01-16 15:36:04 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-01-31 12:23:44 UTC 
Pushed to 23.11.x for 23.11.03