Bug 35387

Summary: Capitalization: Labels in preservation module are not capitalized
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: PreservationAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: david, fridolin.somers, lucas, martin.renvoize, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This fixes the capitalization of some label names in the Preservation module (name -> Name, and barcode -> Barcode).
Version(s) released in:
24.05.00,23.11.01
Circulation function:
Bug Depends on: 30708    
Bug Blocks:    
Attachments: Bug 35387: Fix capitalization of 'name' label in preservation module
Bug 35387: Fix capitalization of 'name' label in preservation module
Bug 35387: (follow-up) Capitalize 'barcode'
Bug 35387: Fix capitalization of 'name' label in preservation module
Bug 35387: (follow-up) Capitalize 'barcode'

Description Tomás Cohen Arazi (tcohen) 2023-11-22 20:50:33 UTC

    
Comment 1 Tomás Cohen Arazi (tcohen) 2023-11-22 20:56:34 UTC
Created attachment 159198 [details] [review]
Bug 35387: Fix capitalization of 'name' label in preservation module

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 David Nind 2023-11-22 21:07:35 UTC
Created attachment 159199 [details] [review]
Bug 35387: Fix capitalization of 'name' label in preservation module

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-11-22 21:12:12 UTC
Testing notes (using KTD):

1. Enable the preservation module (PreservationModule system preference).
2. Go to: Home > Preservation > Trains > New train
3. Note that the name field label is in lower case (name).
4. Apply the patch.
5. Refresh the page.
6. Note that the name field is now correctly labelled as 'Name'.
Comment 4 David Nind 2023-11-22 21:47:11 UTC
Also needs a 'yarn build' after the patch is applied.
Comment 5 Tomás Cohen Arazi (tcohen) 2023-11-23 11:31:36 UTC
Created attachment 159207 [details] [review]
Bug 35387: (follow-up) Capitalize 'barcode'

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Jonathan Druart 2023-11-23 12:19:53 UTC
Created attachment 159208 [details] [review]
Bug 35387: Fix capitalization of 'name' label in preservation module

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2023-11-23 12:19:56 UTC
Created attachment 159209 [details] [review]
Bug 35387: (follow-up) Capitalize 'barcode'

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Katrin Fischer 2023-12-07 11:05:33 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 9 Fridolin Somers 2023-12-07 21:18:24 UTC
Pushed to 23.11.x for 23.11.01
Comment 10 Lucas Gass (lukeg) 2023-12-14 20:48:24 UTC
No preservation module in 23.05.x, no backport.